Added first tests and minor refactorings

Author: moay

src/Command/Recipes/RecipeRepoManagerCommand.php

@@ -25,13 +25,19 @@
  * @package App\Command\Recipes
  * @author moay <[email protected]>
  */
-abstract class RecipeRepoManagerCommand extends Command implements RecipeRepoManagerCommandInterface
+abstract class RecipeRepoManagerCommand extends Command
 {
     const ACTION_NAMESPACE = 'recipes:';
 
     /** @var RecipeRepoManager */
     private $repoManager;
 
+    /** @var string */
+    protected $action;
+
+    /** @var string */
+    protected $description;
+
     /**
      * RecipesInitializeCommand constructor.
      * @param RecipeRepoManager $repoManager
@@ -46,13 +52,13 @@ public function __construct(RecipeRepoManager $repoManager)
     protected function configure()
     {
         $this
-            ->setName(self::ACTION_NAMESPACE . $this->getAction())
-            ->setDescription($this->getDescription());
+            ->setName(self::ACTION_NAMESPACE . $this->action)
+            ->setDescription($this->description);
 
         $description = sprintf(
             '%s a single repo by selecting \'private\', \'official\' or \'contrib\'. Don\'t select any in order to %s all configured repos.',
-            ucfirst($this->getAction()),
-            $this->getAction()
+            ucfirst($this->action),
+            $this->action
         );
 
         $this->addArgument('repo', InputArgument::IS_ARRAY, $description, []);
@@ -83,8 +89,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
             } else {
                 if ($this->repoManager->isConfiguredByDirName($repo)) {
                     try {
-                        $this->repoManager->executeOnRepo($this->getAction(), $repo);
-                        $actionPast = $this->getAction() == 'reset' ? 'resetted' : $this->getAction() . 'd';
+                        $this->repoManager->executeOnRepo($this->action, $repo);
+                        $actionPast = $this->action === 'reset' ? 'resetted' : $this->action . 'd';
                         $io->success(sprintf('%s recipes repo %s.', ucfirst($repo), $actionPast));
                     } catch (RecipeRepoManagerException $e) {
                         $io->error($e->getMessage());
@@ -94,6 +100,5 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 }
             }
         }
-
     }
 }

src/Command/Recipes/RecipeRepoManagerCommandInterface.php

@@ -19,24 +19,9 @@
 class RecipesInitializeCommand extends RecipeRepoManagerCommand
 {
     /** @var string */
-    private $action = 'initialize';
+    protected $action = 'initialize';
 
     /** @var string */
-    private $description = 'Initializes local recipe repos from remote repo';
+    protected $description = 'Initializes local recipe repos from remote repo';
 
-    /**
-     * @return string
-     */
-    public function getAction()
-    {
-        return $this->action;
-    }
-
-    /**
-     * @return string
-     */
-    public function getDescription()
-    {
-        return $this->description;
-    }
 }

src/Command/Recipes/RecipesInitializeCommand.php

@@ -19,24 +19,8 @@
 class RecipesRemoveCommand extends RecipeRepoManagerCommand
 {
     /** @var string */
-    private $action = 'remove';
+    protected $action = 'remove';
 
     /** @var string */
-    private $description = 'Deletes local recipe repos';
-
-    /**
-     * @return string
-     */
-    public function getAction()
-    {
-        return $this->action;
-    }
-
-    /**
-     * @return string
-     */
-    public function getDescription()
-    {
-        return $this->description;
-    }
+    protected $description = 'Deletes local recipe repos';
 }

src/Command/Recipes/RecipesRemoveCommand.php

@@ -19,24 +19,8 @@
 class RecipesResetCommand extends RecipeRepoManagerCommand
 {
     /** @var string */
-    private $action = 'reset';
+    protected $action = 'reset';
 
     /** @var string */
-    private $description = 'Resets local recipe repos by deleting and reinitalizing from remote repo';
-
-    /**
-     * @return string
-     */
-    public function getAction()
-    {
-        return $this->action;
-    }
-
-    /**
-     * @return string
-     */
-    public function getDescription()
-    {
-        return $this->description;
-    }
+    protected $description = 'Resets local recipe repos by deleting and reinitalizing from remote repo';
 }

src/Command/Recipes/RecipesResetCommand.php

@@ -19,24 +19,8 @@
 class RecipesUpdateCommand extends RecipeRepoManagerCommand
 {
     /** @var string */
-    private $action = 'update';
+    protected $action = 'update';
 
     /** @var string */
-    private $description = 'Updates local recipe repos to match the current remote repo';
-
-    /**
-     * @return string
-     */
-    public function getAction()
-    {
-        return $this->action;
-    }
-
-    /**
-     * @return string
-     */
-    public function getDescription()
-    {
-        return $this->description;
-    }
+    protected $description = 'Updates local recipe repos to match the current remote repo';
 }

src/Command/Recipes/RecipesUpdateCommand.php

@@ -45,6 +45,11 @@ public function configure()
             ->setDescription('Provides an overview over the system status');
     }
 
+    /**
+     * @param InputInterface $input
+     * @param OutputInterface $output
+     * @return void
+     */
     public function execute(InputInterface $input, OutputInterface $output)
     {
         $io = new SymfonyStyle($input, $output);

src/Command/System/SystemStatusCommand.php

@@ -43,9 +43,10 @@ public function __construct(RecipeRepoManager $repoManager)
     /**
      * @return Recipe[]
      */
-    public function getLocalRecipes() {
+    public function getLocalRecipes()
+    {
         if (count($this->recipes) == 0) {
-           $this->loadLocalRecipes();
+            $this->loadLocalRecipes();
         }
 
         return $this->recipes;

src/Service/Compiler/LocalRecipeCompiler.php

@@ -43,7 +43,7 @@ private function getPackageLocks(array $requestedPackages)
     {
         $locks = [];
         foreach ($requestedPackages as $package) {
-            $locks[join('/', [$package['author'], $package['package']])] = ['version' => $package['version']];
+            $locks[implode('/', [$package['author'], $package['package']])] = ['version' => $package['version']];
         }
         return $locks;
     }
@@ -65,7 +65,7 @@ private function getManifests(array $localRecipes, array $officialResponse)
                 'files' => $this->getRecipeFiles($recipe),
                 'origin' => $recipe->getOfficialPackageName() . ':'  . $recipe->getVersion() . '@private:master',
                 'not_installable' => $recipe->isManifestValid() === false,
-                'is_contrib' => $recipe->getRepoSlug() == 'contrib'
+                'is_contrib' => $recipe->getRepoSlug() === 'contrib'
             ];
 
             if (empty($manifest['files'])) {

src/Service/Compiler/PackagesCompiler.php

@@ -58,6 +58,8 @@ public function __construct(
      * Provides a proxy for the aliases.json call, which provides official Symfony aliases.
      *
      * @return array
+     * @throws \Exception
+     * @throws \Http\Client\Exception
      */
     public function getAliases()
     {
@@ -69,6 +71,8 @@ public function getAliases()
      * Provides a proxy for the versions.json call, which provides version information for Symfony.
      *
      * @return array
+     * @throws \Exception
+     * @throws \Http\Client\Exception
      */
     public function getVersions()
     {
@@ -81,6 +85,8 @@ public function getVersions()
      *
      * @param string $packagesRequestString
      * @return array|string
+     * @throws \Exception
+     * @throws \Http\Client\Exception
      */
     public function getPackages(string $packagesRequestString)
     {
@@ -91,6 +97,8 @@ public function getPackages(string $packagesRequestString)
     /**
      * @param Request $request
      * @return array|string
+     * @throws \Exception
+     * @throws \Http\Client\Exception
      */
     private function getDecodedResponse(Request $request)
     {