fix(workflow): remove duplicate error logging and status setting

Centralize error handling by removing redundant error logging to output window since errors are now displayed in modal. The workflow status is set once via event bus adapter.

Author: moazbuilds

src/cli/tui/routes/workflow/workflow-shell.tsx

@@ -95,8 +95,8 @@ export function WorkflowShell(props: WorkflowShellProps) {
   const isErrorModalActive = () => errorMessage() !== null
 
   const handleWorkflowError = (data: { reason: string }) => {
+    // Only set error message - workflow status is already set via event bus adapter
     setErrorMessage(data.reason)
-    ui.actions.setWorkflowStatus("error")
   }
 
   const handleErrorModalClose = () => {

src/workflows/execution/errors.ts

@@ -91,9 +91,9 @@ ${engine}: ${errorMessage}`;
     debug(`[DEBUG workflow] isFileNotFoundError=true, emitting workflow:error`);
     debug(`[DEBUG workflow] errorMsg=${errorMsg}`);
     emitter.updateAgentStatus(uniqueAgentId, 'failed');
-    emitter.logMessage(uniqueAgentId, errorMsg);
 
-    // Set workflow status to error and emit error event for toast
+    // Set workflow status to error and emit error event for modal
+    // Don't log to output window - the modal will display the error
     debug(`[DEBUG workflow] Calling emitter.setWorkflowStatus('error')`);
     emitter.setWorkflowStatus('error');
     debug(`[DEBUG workflow] Emitting process event 'workflow:error'`);
@@ -109,10 +109,10 @@ ${engine}: ${errorMessage}`;
 ${engine}: ${error instanceof Error ? error.message : String(error)}`;
   debug(`[DEBUG workflow] Generic error path`);
   debug(`[DEBUG workflow] errorMsg=${errorMsg}`);
-  emitter.logMessage(uniqueAgentId, errorMsg);
   emitter.updateAgentStatus(uniqueAgentId, 'failed');
 
-  // Set workflow status to error and emit error event for toast
+  // Set workflow status to error and emit error event for modal
+  // Don't log to output window - the modal will display the error
   debug(`[DEBUG workflow] Calling emitter.setWorkflowStatus('error') for generic error`);
   emitter.setWorkflowStatus('error');
   debug(`[DEBUG workflow] Emitting process event 'workflow:error' for generic error`);

src/workflows/execution/run.ts

@@ -528,10 +528,8 @@ export async function runWorkflow(options: RunWorkflowOptions = {}): Promise<voi
 
     const errorMsg = error instanceof Error ? error.message : String(error);
 
-    emitter.logMessage('workflow', `\n${'═'.repeat(80)}\nWORKFLOW FAILED\n${'═'.repeat(80)}`);
-    emitter.logMessage('workflow', `Error: ${errorMsg}`);
-
-    // Set workflow status to error and emit error event for toast
+    // Set workflow status to error and emit error event for modal
+    // Don't log to output window - the modal will display the error
     emitter.setWorkflowStatus('error');
     (process as NodeJS.EventEmitter).emit('workflow:error', { reason: errorMsg });