Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Commit 1ee7a0f

Browse files
author
Marlow Payne
committed
Merge pull request #93 from mobify/release-v2.4.0
Release v2.4.0
2 parents b2cf0b3 + 0e42a49 commit 1ee7a0f

File tree

4 files changed

+337
-1
lines changed

4 files changed

+337
-1
lines changed

‎CHANGELOG‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
2.4.0
2+
- Add a sass-lint config file
13
2.3.7
24
- Add Writing Checklist
35
- Fix doc error wrt function expression hoisting

‎css/.sass-lint.yml‎

Lines changed: 330 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,330 @@
1+
# sass-lint config generated by make-sass-lint-config v0.1.1
2+
3+
files:
4+
include: '**/*.s+(a|c)ss'
5+
ignore:
6+
- 'node_modules/**/*.scss'
7+
- 'app/global/styles/base/**/*.scss'
8+
options:
9+
formatter: stylish
10+
merge-default-rules: false
11+
rules:
12+
bem-depth:
13+
- 2
14+
- max-depth: 1
15+
border-zero:
16+
- 2
17+
- convention: zero
18+
brace-style:
19+
- 2
20+
- allow-single-line: false
21+
class-name-format:
22+
- 2
23+
- convention: hyphenatedbem
24+
clean-import-paths:
25+
- 2
26+
- filename-extension: false
27+
leading-underscore: false
28+
empty-line-between-blocks:
29+
- 2
30+
- ignore-single-line-rulesets: true
31+
extends-before-declarations: 2
32+
extends-before-mixins: 2
33+
final-newline:
34+
- 2
35+
- include: true
36+
force-attribute-nesting: 0
37+
force-element-nesting: 0
38+
force-pseudo-nesting: 0
39+
function-name-format:
40+
- 2
41+
- allow-leading-underscore: true
42+
convention: '[a-z]|-{3}|_{3}|[^_]_[^_]'
43+
hex-length:
44+
- 2
45+
- style: short
46+
hex-notation:
47+
- 2
48+
- style: lowercase
49+
id-name-format:
50+
- 2
51+
- convention: hyphenatedbem
52+
indentation:
53+
- 2
54+
- size: 4
55+
leading-zero:
56+
- 2
57+
- include: true
58+
mixin-name-format:
59+
- 2
60+
- allow-leading-underscore: true
61+
convention: '[a-z]|-{3}|_{3}|[^_]_[^_]'
62+
mixins-before-declarations: 2
63+
nesting-depth:
64+
- 2
65+
- max-depth: 4
66+
no-color-keyword: 0
67+
no-color-literals: 0
68+
no-css-comments: 2
69+
no-debug: 2
70+
no-duplicate-properties: 2
71+
no-empty-rulesets: 0
72+
no-extends: 0
73+
no-ids: 0
74+
no-important: 0
75+
no-invalid-hex: 2
76+
no-mergeable-selectors: 2
77+
no-misspelled-properties:
78+
- 2
79+
- extra-properties: []
80+
no-qualifying-elements:
81+
- 2
82+
- allow-element-with-attribute: true
83+
allow-element-with-class: false
84+
allow-element-with-id: false
85+
no-trailing-zero: 2
86+
no-transition-all: 0
87+
no-url-protocols: 2
88+
placeholder-in-extend: 2
89+
placeholder-name-format:
90+
- 2
91+
- convention: hyphenatedbem
92+
property-sort-order:
93+
- 2
94+
- ignore-custom-properties: false
95+
order:
96+
- content
97+
- quotes
98+
- counter-reset
99+
- counter-increment
100+
- position
101+
- top
102+
- right
103+
- bottom
104+
- left
105+
- z-index
106+
- float
107+
- clear
108+
- display
109+
- overflow
110+
- overflow-x
111+
- overflow-y
112+
- clip
113+
- table-layout
114+
- empty-cells
115+
- caption-side
116+
- border-spacing
117+
- border-collapse
118+
- flex-flow
119+
- flex-direction
120+
- flex-wrap
121+
- justify-content
122+
- align-items
123+
- align-content
124+
- flex
125+
- flex-grow
126+
- flex-shrink
127+
- flex-basis
128+
- align-self
129+
- order
130+
- box-sizing
131+
- width
132+
- min-width
133+
- max-width
134+
- height
135+
- min-height
136+
- max-height
137+
- margin
138+
- margin-top
139+
- margin-right
140+
- margin-bottom
141+
- margin-left
142+
- padding
143+
- padding-top
144+
- padding-right
145+
- padding-bottom
146+
- padding-left
147+
- border
148+
- border-width
149+
- border-style
150+
- border-color
151+
- border-top
152+
- border-top-width
153+
- border-top-style
154+
- border-top-color
155+
- border-right
156+
- border-right-width
157+
- border-right-style
158+
- border-right-color
159+
- border-bottom
160+
- border-bottom-width
161+
- border-bottom-style
162+
- border-bottom-color
163+
- border-left
164+
- border-left-width
165+
- border-left-style
166+
- border-left-color
167+
- visibility
168+
- opacity
169+
- border-radius
170+
- border-top-left-radius
171+
- border-top-right-radius
172+
- border-bottom-right-radius
173+
- border-bottom-left-radius
174+
- border-image
175+
- border-image-source
176+
- border-image-slice
177+
- border-image-width
178+
- border-image-outset
179+
- border-image-repeat
180+
- background
181+
- background-color
182+
- background-image
183+
- background-repeat
184+
- background-attachment
185+
- background-position
186+
- background-position-x
187+
- background-position-y
188+
- background-origin
189+
- background-size
190+
- background-clip
191+
- box-shadow
192+
- box-decoration-break
193+
- outline
194+
- outline-width
195+
- outline-style
196+
- outline-color
197+
- filter
198+
- color
199+
- font
200+
- font-family
201+
- font-style
202+
- font-weight
203+
- font-variant
204+
- font-size
205+
- font-size-adjust
206+
- line-height
207+
- letter-spacing
208+
- word-spacing
209+
- direction
210+
- word-wrap
211+
- overflow-wrap
212+
- word-break
213+
- hyphens
214+
- white-space
215+
- text-align
216+
- text-align-last
217+
- text-indent
218+
- text-overflow
219+
- text-transform
220+
- text-decoration
221+
- text-shadow
222+
- text-rendering
223+
- text-size-adjust
224+
- vertical-align
225+
- tab-size
226+
- list-style
227+
- list-style-position
228+
- list-style-type
229+
- list-style-image
230+
- transform
231+
- transform-function
232+
- transform-origin
233+
- transform-style
234+
- perspective
235+
- perspective-origin
236+
- backface-visibility
237+
- transition
238+
- transition-property
239+
- transition-duration
240+
- transition-timing-function
241+
- transition-delay
242+
- animation
243+
- animation-name
244+
- animation-duration
245+
- animation-timing-function
246+
- animation-delay
247+
- animation-iteration-count
248+
- animation-direction
249+
- animation-fill-mode
250+
- animation-play-state
251+
- cursor
252+
- user-select
253+
- resize
254+
- pointer-events
255+
- '-webkit-appearance'
256+
- '-moz-appearance'
257+
- '-webkit-overflow-scrolling'
258+
- '-webkit-tap-highlight-color'
259+
- '-webkit-text-stroke'
260+
property-units:
261+
- 0
262+
- global:
263+
- ch
264+
- em
265+
- ex
266+
- rem
267+
- cm
268+
- in
269+
- mm
270+
- pc
271+
- pt
272+
- px
273+
- q
274+
- vh
275+
- vw
276+
- vmin
277+
- vmax
278+
- deg
279+
- grad
280+
- rad
281+
- turn
282+
- ms
283+
- s
284+
- Hz
285+
- kHz
286+
- dpi
287+
- dpcm
288+
- dppx
289+
- '%'
290+
per-property: {}
291+
quotes:
292+
- 0
293+
- style: double
294+
shorthand-values:
295+
- 2
296+
- allowed-shorthands:
297+
- 1
298+
- 2
299+
- 3
300+
single-line-per-selector: 2
301+
space-after-bang:
302+
- 2
303+
- include: false
304+
space-after-colon:
305+
- 2
306+
- include: true
307+
space-after-comma:
308+
- 2
309+
- include: true
310+
space-before-bang:
311+
- 2
312+
- include: true
313+
space-before-brace:
314+
- 2
315+
- include: true
316+
space-before-colon: 2
317+
space-between-parens:
318+
- 2
319+
- include: false
320+
trailing-semicolon: 2
321+
url-quotes: 2
322+
variable-for-property:
323+
- 2
324+
- properties:
325+
- font
326+
variable-name-format:
327+
- 2
328+
- allow-leading-underscore: true
329+
convention: '[a-z]|-{3}|_{3}|[^_]_[^_]'
330+
zero-unit: 2

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "mobify-code-style",
3-
"version": "2.3.7",
3+
"version": "2.4.0",
44
"description": "Code style guide and linting tools for Mobify",
55
"main": "index.js",
66
"scripts": {

‎swift/README.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
The Mobify style guide for Swift is largely embodied in the [Astro](https://github.com/mobify/astro) Swift code. Think of that codebase as "canonical" Swift code.
2+
3+
We also follow the [Swift API design guidelines](https://swift.org/documentation/api-design-guidelines/) in all of the code we write.
4+
15
Strings
26
=======
37

0 commit comments

Comments
 (0)