Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Commit 91f9ad6

Browse files
author
Marlow Payne
committed
Fix #43 by updating all underlines in Sass code examples
1 parent 3a87ecb commit 91f9ad6

File tree

3 files changed

+34
-33
lines changed

3 files changed

+34
-33
lines changed

CHANGELOG

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
2.5.2
2+
- Fix #43 by updating all underlines in Sass code examples
23
- Fix #114 by removing invalid options from CSSComb config file
34
- Add a React rule to make sure propTypes are ordered, required ones declared first and callbacks (e.g. onChange) declared last.
45
- Update ES6 indent rule on switch statements

css/comments/Readme.md

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ Headings in CSS comments should follow the following format:
1515

1616
```
1717
// Heading Level 1
18-
// ===============
18+
// ===
1919
//
2020
// Heading Level 2
21-
// ---------------
21+
// ---
2222
//
2323
// ### Heading Level 3 and beyond
2424
```
@@ -36,16 +36,16 @@ For example...
3636

3737
```
3838
// Documentation Headings Example
39-
// ==============================
39+
// ===
4040
//
4141
// The First Example
42-
// -----------------
42+
// ---
4343
//
4444
// Notice how there is only a single line between the level 1 and 2 headings above.
4545
4646
4747
// The Second Example
48-
// ------------------
48+
// ---
4949
//
5050
// All headings that don't immediately follow another heading will have two spaces
5151
// above, like the heading directly above.
@@ -100,7 +100,7 @@ Bad example:
100100

101101
```
102102
// Buttons
103-
// =======
103+
// ===
104104
105105
.button {
106106
display: block; // This must be a block because reasons. Reasons like because
@@ -114,7 +114,7 @@ Better example:
114114

115115
```
116116
// Buttons
117-
// =======
117+
// ===
118118
//
119119
// Notes:
120120
//
@@ -132,7 +132,7 @@ Notice how we can apply the same line comment to multiple lines:
132132

133133
```
134134
// Modal
135-
// =====
135+
// ===
136136
//
137137
// Notes:
138138
//
@@ -157,7 +157,7 @@ Example:
157157

158158
```
159159
// Checkout
160-
// ========
160+
// ===
161161
//
162162
// @url http://www.website.com/checkout
163163
```
@@ -169,26 +169,26 @@ Example:
169169

170170
```
171171
// Checkout
172-
// ========
172+
// ===
173173
//
174174
// @url http://www.website.com/checkout
175175
176176
.t-checkout {
177177
178178
// Global
179-
// ------
179+
// ---
180180
//
181181
// ...
182182
183183
184184
// Your Details
185-
// ------------
185+
// ---
186186
//
187187
// ...
188188
189189
190190
// Credit Card Info
191-
// ----------------
191+
// ---
192192
//
193193
// ...
194194
}
@@ -198,13 +198,13 @@ Alternatively:
198198

199199
```
200200
// Checkout
201-
// ========
201+
// ===
202202
//
203203
// @url http://www.website.com/checkout
204204
205205
206206
// Global
207-
// ------
207+
// ---
208208
//
209209
// ...
210210
@@ -213,7 +213,7 @@ Alternatively:
213213
214214
215215
// Your Details
216-
// ------------
216+
// ---
217217
//
218218
// ...
219219
@@ -222,7 +222,7 @@ Alternatively:
222222
223223
224224
// Credit Card Info
225-
// ----------------
225+
// ---
226226
//
227227
// ...
228228
@@ -235,7 +235,7 @@ the base template scope and with a level 2 heading. Example:
235235

236236
```
237237
// Checkout
238-
// ========
238+
// ===
239239
//
240240
// @url http://www.website.com/checkout
241241
@@ -244,14 +244,14 @@ the base template scope and with a level 2 heading. Example:
244244
245245
246246
// Checkout: Form
247-
// --------------
247+
// ---
248248
249249
.t-checkout__form {
250250
}
251251
252252
253253
// Checkout: Sidebar
254-
// -----------------
254+
// ---
255255
256256
.t-checkout__sidebar {
257257
}
@@ -278,7 +278,7 @@ SCSS file.
278278

279279
```
280280
// Breadcrumbs
281-
// ===========
281+
// ===
282282
283283
.c-breadcrumbs {
284284
}
@@ -293,7 +293,7 @@ use a level 2 heading for each sub-component.
293293

294294
```
295295
// Breadcrumbs: Link
296-
// -----------------
296+
// ---
297297
298298
.c-breadcrumbs__link {
299299
}
@@ -308,7 +308,7 @@ Notice the lack of any "Link Arrow" heading in the following example:
308308

309309
```
310310
// Breadcrumbs: Link
311-
// -----------------
311+
// ---
312312
313313
.c-breadcrumbs__link {
314314
}
@@ -331,7 +331,7 @@ Method 1: Nested
331331

332332
```
333333
// Breadcrumbs: Link
334-
// -----------------
334+
// ---
335335
336336
.c-breadcrumbs__link {
337337
@@ -344,7 +344,7 @@ Method 2: Unnested
344344

345345
```
346346
// Breadcrumbs: Link
347-
// -----------------
347+
// ---
348348
349349
.c-breadcrumbs__link {
350350
}
@@ -360,14 +360,14 @@ breadcrumb link styles. That could be enough to warrant a heading:
360360

361361
```
362362
// Breadcrumbs: Link
363-
// -----------------
363+
// ---
364364
365365
.c-breadcrumbs__link {
366366
}
367367
368368
369369
// Breadcrumbs: Current Link
370-
// -------------------------
370+
// ---
371371
372372
.c-breadcrumbs__link.c--current {
373373
}
@@ -406,7 +406,7 @@ An example of both the doc block and dependencies can be seen here:
406406

407407
```
408408
// My Function
409-
// ===========
409+
// ===
410410
//
411411
// Standard definition section goes here.
412412
//

css/sass-best-practices/readme.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ The second aspect of comments are the comments themselves! There are three types
291291

292292
```scss
293293
// My Component
294-
// ============
294+
// ===
295295
//
296296
// This is a general comment that applies to the whole of this section. It can contain
297297
// any information that is important to the file, styles and classes inside.
@@ -308,7 +308,7 @@ Be aware that these notes typically only refer to the code directly beneath it,
308308

309309
```scss
310310
// My Component
311-
// ============
311+
// ===
312312
//
313313
// Notes:
314314
//
@@ -326,7 +326,7 @@ Be aware that these notes typically only refer to the code directly beneath it,
326326

327327

328328
// My Component: Inner
329-
// -------------------
329+
// ---
330330
//
331331
// Notes:
332332
//
@@ -348,7 +348,7 @@ This is a rare use case, but can be useful sometimes when you have the same set
348348

349349
```scss
350350
// My Component
351-
// ============
351+
// ===
352352
//
353353
// Notes:
354354
//
@@ -360,7 +360,7 @@ This is a rare use case, but can be useful sometimes when you have the same set
360360

361361

362362
// My Component: Inner
363-
// -------------------
363+
// ---
364364

365365
.c-my-component__inner {
366366
display: none; // A

0 commit comments

Comments
 (0)