Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Commit ecba389

Browse files
committed
Merge pull request #79 from mobify/fix-lint-comb-quote-rules
Fix lint/comb rule to support both single and double quotes
2 parents 21b8182 + d4f3b56 commit ecba389

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

CHANGELOG

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
2.3.3
2+
- Change scss-lint rule: disable the quotes rules
3+
- Change CSScomb rule: disable the quotes rules
14
2.3.2
25
- Update documentation: "Tools & Frameworks" section in the CSS introduction
36
2.3.1

css/.csscomb.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,10 @@
1414
"element-case": "lower",
1515
"eof-newline": true,
1616
"leading-zero": false,
17-
"quotes": "single",
1817
"rule-indent": " ",
1918
"stick-brace": " ",
2019
"unitless-zero": true,
21-
"quotes": "single",
20+
"quotes": false,
2221
"remove-empty-rulesets": true,
2322
"space-before-closing-brace": "\n",
2423
"space-before-colon": "",

css/.scss-lint.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,8 +241,8 @@ linters:
241241
# Lint quote marks for all strings?
242242
# Configure: `single_quotes` or `double_quotes`
243243
StringQuotes:
244-
enabled: true
245-
style: single_quotes
244+
enabled: false
245+
style: double_quotes
246246

247247
# Report lack of semicolon at the end of the last rule in a ruleset?
248248
TrailingSemicolon:

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "mobify-code-style",
3-
"version": "2.3.2",
3+
"version": "2.3.3",
44
"description": "Code style guide and linting tools for Mobify",
55
"main": "index.js",
66
"scripts": {

0 commit comments

Comments
 (0)