Skip to content
This repository was archived by the owner on Aug 5, 2020. It is now read-only.

Commit 366608b

Browse files
authored
Merge pull request #70 from mobify/master
Master
2 parents d1a7992 + d482d7f commit 366608b

File tree

4 files changed

+25
-23
lines changed

4 files changed

+25
-23
lines changed

CHANGELOG

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
- Use [selenium-download](https://github.com/groupon/selenium-download) to manage downloading of Selenium server and Chromedriver.
33
- BREAKING CHANGES
44
- This requires node 4+ and Chrome 54 or higher.
5+
1.8.0
6+
- Use [selenium-download](https://github.com/groupon/selenium-download) to manage downloading of Selenium server and Chromedriver. Compatible with node 0.12.x.
57
1.7.0
68
- Introduces 'waitForContextsReady' command.
79
1.6.3

circle.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
machine:
22
node:
3-
version: 4.4.3
3+
version: 0.12.13
44

55
dependencies:
66
override:

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nightwatch-commands",
3-
"version": "2.0.0",
3+
"version": "1.8.0",
44
"description": "A set of Mobify specific custom commands for Nightwatch.js",
55
"repository": {
66
"type": "git",

selenium/install.js

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,29 @@
1-
const fs = require('fs')
2-
const mkdirp = require('mkdirp')
3-
const path = require('path')
4-
const selenium = require('selenium-download')
1+
var fs = require('fs');
2+
var mkdirp = require('mkdirp');
3+
var path = require('path');
4+
var selenium = require('selenium-download');
55

66
// Download Selenium server and Chromedriver
7-
selenium.ensure(__dirname, error => {
7+
selenium.ensure(__dirname, function(error) {
88
if (error) {
9-
console.error(error.stack)
9+
console.error(error.stack);
1010
} else {
11-
// Rename so that we don't need to update paths in project configs
12-
const oldSeleniumPath = path.join(__dirname, 'selenium.jar')
13-
const newSeleniumPath = path.join(__dirname, 'selenium-server.jar')
11+
// Rename so that we don't need to update paths in project configs
12+
var oldSeleniumPath = path.join(__dirname, 'selenium.jar');
13+
var newSeleniumPath = path.join(__dirname, 'selenium-server.jar');
1414

15-
fs.rename(oldSeleniumPath, newSeleniumPath, error => {
16-
if (error) console.log(error)
17-
return
18-
})
15+
fs.rename(oldSeleniumPath, newSeleniumPath, function(error) {
16+
if (error) console.log(error);
17+
return;
18+
});
1919

20-
mkdirp(path.join(__dirname, 'drivers'))
21-
const oldChromedriverPath = path.join(__dirname, 'chromedriver')
22-
const newChromedriverPath = path.join(__dirname, 'drivers', 'chromedriver')
20+
mkdirp(path.join(__dirname, 'drivers'));
21+
var oldChromedriverPath = path.join(__dirname, 'chromedriver');
22+
var newChromedriverPath = path.join(__dirname, 'drivers', 'chromedriver');
2323

24-
fs.rename(oldChromedriverPath, newChromedriverPath, error => {
25-
if (error) console.log(error)
26-
return
27-
})
24+
fs.rename(oldChromedriverPath, newChromedriverPath, function(error) {
25+
if (error) console.log(error);
26+
return;
27+
});
2828
}
29-
})
29+
});

0 commit comments

Comments
 (0)