Update scrolluntilvisible-for-fragments.md to stop infinite loop #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR improves the scrollUntilVisible implementation to handle edge cases in fragment-based layouts and slow-loading content. Key changes Retry limit added: Loops are capped at 10 retries to prevent infinite loops in CI pipelines. Slow UI support: Added waitForAnimationToEnd after each swipe to ensure elements have time to render after scrolling. Explicit final assertion: Ensures tests fail clearly if the element is never found, improving test reliability. Benefits Works reliably with fragment-based layouts. Prevents CI hangs due to infinite loops. Handles network-loaded or animation-heavy screens gracefully. Provides clear failure messages when elements are missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the scrollUntilVisible implementation to handle edge cases in fragment-based layouts and slow-loading content.
Key changes
Retry limit added: Loops are capped at 10 retries to prevent infinite loops in CI pipelines.
Slow UI support: Added waitForAnimationToEnd after each swipe to ensure elements have time to render after scrolling.
Explicit final assertion: Ensures tests fail clearly if the element is never found, improving test reliability.
Benefits
Works reliably with fragment-based layouts.
Prevents CI hangs due to infinite loops.
Handles network-loaded or animation-heavy screens gracefully.
Provides clear failure messages when elements are missing.