feat: automatically install wda on ios simulator

Author: gmegidish

devices/simulator.go

@@ -2,19 +2,15 @@ package devices
 
 import (
 	"bytes"
-	"context"
 	"encoding/json"
 	"fmt"
-	"io"
 	"log"
-	"net/http"
 	"os"
 	"os/exec"
 	"time"
 
 	"github.com/mobile-next/mobilecli/devices/wda"
 	"github.com/mobile-next/mobilecli/utils"
-	"github.com/otiai10/copy"
 )
 
 // AppInfo corresponds to the structure from plutil output
@@ -228,76 +224,33 @@ func (s SimulatorDevice) WaitUntilAppExists(bundleID string) error {
 }
 
 func (s SimulatorDevice) DownloadWebDriverAgent() (string, error) {
-	url := "https://github.com/appium/WebDriverAgent/releases/download/v9.13.0/WebDriverAgentRunner-Runner.zip"
+	url := "https://github.com/appium/WebDriverAgent/releases/download/v9.15.1/WebDriverAgentRunner-Build-Sim-arm64.zip"
 
 	tmpFile, err := os.CreateTemp("", "wda-*.zip")
-	log.Printf("Created temp file: %s", tmpFile.Name())
 	if err != nil {
 		return "", fmt.Errorf("failed to create temp file: %v", err)
 	}
+	tmpFile.Close()
 
-	client := &http.Client{
-		Timeout: 5 * time.Second,
-	}
-
-	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
-	defer cancel()
-
-	req, err := http.NewRequestWithContext(ctx, "GET", url, nil)
-	if err != nil {
-		return "", fmt.Errorf("failed to download WebDriverAgent: %v", err)
-	}
+	log.Printf("Downloading WebDriverAgent to: %s", tmpFile.Name())
 
-	resp, err := client.Do(req)
+	err = utils.DownloadFile(url, tmpFile.Name())
 	if err != nil {
+		os.Remove(tmpFile.Name())
 		return "", fmt.Errorf("failed to download WebDriverAgent: %v", err)
 	}
 
-	defer resp.Body.Close()
-
-	if resp.StatusCode != http.StatusOK {
-		return "", fmt.Errorf("failed to download WebDriverAgent: status code %d", resp.StatusCode)
-	}
-
-	_, err = io.Copy(tmpFile, resp.Body)
-	if err != nil {
-		return "", err
-	}
-
-	defer tmpFile.Close()
-
 	return tmpFile.Name(), nil
 }
 
-func copyFile(src, dst string) error {
-	srcFile, err := os.Open(src)
-	if err != nil {
-		return fmt.Errorf("failed to open source file %s: %v", src, err)
-	}
-	defer srcFile.Close()
-
-	dstFile, err := os.Create(dst)
-	if err != nil {
-		return fmt.Errorf("failed to create destination file %s: %v", dst, err)
-	}
-	defer dstFile.Close()
-
-	_, err = io.Copy(dstFile, srcFile)
-	if err != nil {
-		return fmt.Errorf("failed to copy file %s: %v", src, err)
-	}
-
-	return nil
-}
-
 func (s SimulatorDevice) InstallWebDriverAgent() error {
 
 	file, err := s.DownloadWebDriverAgent()
 	if err != nil {
 		return fmt.Errorf("failed to download WebDriverAgent: %v", err)
 	}
 
-	// defer os.Remove(file)
+	defer os.Remove(file)
 
 	log.Printf("Downloaded WebDriverAgent to %s", file)
 
@@ -306,49 +259,9 @@ func (s SimulatorDevice) InstallWebDriverAgent() error {
 		return fmt.Errorf("failed to unzip WebDriverAgent: %v", err)
 	}
 
+	defer os.RemoveAll(dir)
 	log.Printf("Unzipped WebDriverAgent to %s", dir)
 
-	// copy frameworks into this directory
-	frameworks := []string{
-		"Testing.framework",
-		"WebDriverAgentRunner.xctest",
-		"XCTAutomationSupport.framework",
-		"XCTest.framework",
-		"XCTestCore.framework",
-		"XCTestSupport.framework",
-		"XCUIAutomation.framework",
-		"XCUnit.framework",
-	}
-
-	files := []string{
-		"libXCTestSwiftSupport.dylib",
-	}
-
-	xcodePath := "/Applications/Xcode.app/Contents/Developer"
-	iPhoneSimulatorPath := xcodePath + "/Platforms/iPhoneSimulator.platform/Developer"
-	frameworksPath := iPhoneSimulatorPath + "/Library/Frameworks/"
-
-	// copy recursively all files in frameworks to the simulator
-	for _, framework := range frameworks {
-		src := frameworksPath + framework
-		dst := dir + "/" + framework
-		err = copy.Copy(src, dst)
-		if err != nil {
-			os.RemoveAll(dir)
-			return fmt.Errorf("failed to copy framework %s: %v", src, err)
-		}
-	}
-
-	for _, file := range files {
-		src := iPhoneSimulatorPath + "/usr/lib/" + file
-		dst := dir + "/" + file
-		err = copyFile(src, dst)
-		if err != nil {
-			os.RemoveAll(dir)
-			return fmt.Errorf("failed to copy file %s: %v", src, err)
-		}
-	}
-
 	err = InstallApp(s.UDID, dir+"/WebDriverAgentRunner-Runner.app")
 	if err != nil {
 		return fmt.Errorf("failed to install WebDriverAgent: %v", err)
@@ -359,7 +272,6 @@ func (s SimulatorDevice) InstallWebDriverAgent() error {
 		return fmt.Errorf("failed to wait for WebDriverAgent to be installed: %v", err)
 	}
 
-	defer os.RemoveAll(dir)
 	return nil
 }
 
@@ -384,11 +296,10 @@ func (s SimulatorDevice) StartAgent() error {
 
 		if !installed {
 			log.Printf("WebdriverAgent is not installed. Will try to install now")
-			return fmt.Errorf("WebdriverAgent is not installed")
-			// err = s.InstallWebDriverAgent()
-			// if err != nil {
-			// return fmt.Errorf("SimulatorDevice: failed to install WebDriverAgent: %v", err)
-			// }
+			err = s.InstallWebDriverAgent()
+			if err != nil {
+				return fmt.Errorf("SimulatorDevice: failed to install WebDriverAgent: %v", err)
+			}
 		}
 
 		webdriverPackageName := "com.facebook.WebDriverAgentRunner.xctrunner"

go.mod

@@ -6,7 +6,6 @@ toolchain go1.23.5
 
 require (
 	github.com/mholt/archiver v3.1.1+incompatible
-	github.com/otiai10/copy v1.14.1
 	github.com/spf13/cobra v1.9.1
 )
 
@@ -17,11 +16,8 @@ require (
 	github.com/google/go-cmp v0.6.0 // indirect
 	github.com/inconshreveable/mousetrap v1.1.0 // indirect
 	github.com/nwaples/rardecode v1.1.0 // indirect
-	github.com/otiai10/mint v1.6.3 // indirect
 	github.com/pierrec/lz4 v2.6.1+incompatible // indirect
 	github.com/spf13/pflag v1.0.6 // indirect
 	github.com/ulikunitz/xz v0.5.9 // indirect
 	github.com/xi2/xz v0.0.0-20171230120015-48954b6210f8 // indirect
-	golang.org/x/sync v0.15.0 // indirect
-	golang.org/x/sys v0.33.0 // indirect
 )

go.sum

@@ -23,10 +23,6 @@ github.com/mholt/archiver v3.1.1+incompatible h1:1dCVxuqs0dJseYEhi5pl7MYPH9zDa1w
 github.com/mholt/archiver v3.1.1+incompatible/go.mod h1:Dh2dOXnSdiLxRiPoVfIr/fI1TwETms9B8CTWfeh7ROU=
 github.com/nwaples/rardecode v1.1.0 h1:vSxaY8vQhOcVr4mm5e8XllHWTiM4JF507A0Katqw7MQ=
 github.com/nwaples/rardecode v1.1.0/go.mod h1:5DzqNKiOdpKKBH87u8VlvAnPZMXcGRhxWkRpHbbfGS0=
-github.com/otiai10/copy v1.14.1 h1:5/7E6qsUMBaH5AnQ0sSLzzTg1oTECmcCmT6lvF45Na8=
-github.com/otiai10/copy v1.14.1/go.mod h1:oQwrEDDOci3IM8dJF0d8+jnbfPDllW6vUjNc3DoZm9I=
-github.com/otiai10/mint v1.6.3 h1:87qsV/aw1F5as1eH1zS/yqHY85ANKVMgkDrf9rcxbQs=
-github.com/otiai10/mint v1.6.3/go.mod h1:MJm72SBthJjz8qhefc4z1PYEieWmy8Bku7CjcAqyUSM=
 github.com/pierrec/lz4 v2.6.1+incompatible h1:9UY3+iC23yxF0UfGaYrGplQ+79Rg+h/q9FV9ix19jjM=
 github.com/pierrec/lz4 v2.6.1+incompatible/go.mod h1:pdkljMzZIN41W+lC3N2tnIh5sFi+IEE17M5jbnwPHcY=
 github.com/pkg/diff v0.0.0-20210226163009-20ebb0f2a09e/go.mod h1:pJLUxLENpZxwdsKMEsNbx1VGcRFpLqf3715MtcvvzbA=
@@ -42,10 +38,6 @@ github.com/ulikunitz/xz v0.5.9 h1:RsKRIA2MO8x56wkkcd3LbtcE/uMszhb6DpRf+3uwa3I=
 github.com/ulikunitz/xz v0.5.9/go.mod h1:nbz6k7qbPmH4IRqmfOplQw/tblSgqTqBwxkY0oWt/14=
 github.com/xi2/xz v0.0.0-20171230120015-48954b6210f8 h1:nIPpBwaJSVYIxUFsDv3M8ofmx9yWTog9BfvIu0q41lo=
 github.com/xi2/xz v0.0.0-20171230120015-48954b6210f8/go.mod h1:HUYIGzjTL3rfEspMxjDjgmT5uz5wzYJKVo23qUhYTos=
-golang.org/x/sync v0.15.0 h1:KWH3jNZsfyT6xfAfKiz6MRNmd46ByHDYaZ7KSkCtdW8=
-golang.org/x/sync v0.15.0/go.mod h1:1dzgHSNfp02xaA81J2MS99Qcpr2w7fw1gpm99rleRqA=
-golang.org/x/sys v0.33.0 h1:q3i8TbbEz+JRD9ywIRlyRAQbM0qF7hu24q3teo2hbuw=
-golang.org/x/sys v0.33.0/go.mod h1:BJP2sWEmIv4KK5OTEluFJCKSidICx8ciO85XgH3Ak8k=
 golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=