feat: support scale and quality for android mjpeg

Author: gmegidish

README.md

@@ -150,8 +150,8 @@ mobilecli io text --device <device-id> 'hello world'
 - `HOME` - Home button
 - `BACK` - Back button (Android only)
 - `POWER` - Power button
-- `VOLUME_UP` - Volume up
-- `VOLUME_DOWN` - Volume down
+- `VOLUME_UP`, `VOLUME_DOWN` - Volume up and down
+- `DPAD_UP`, `DPAD_DOWN`, `DPAD_LEFT`, `DPAD_RIGHT`, `DPAD_CENTER` - D-pad controls (Android only)
 
 ## Platform-Specific Notes
 

cli/screenshot.go

@@ -6,6 +6,7 @@ import (
 	"os"
 
 	"github.com/mobile-next/mobilecli/commands"
+	"github.com/mobile-next/mobilecli/devices"
 	"github.com/spf13/cobra"
 )
 
@@ -77,7 +78,7 @@ var screencaptureCmd = &cobra.Command{
 		}
 
 		// Start screen capture and stream to stdout
-		err = targetDevice.StartScreenCapture(screencaptureFormat, func(data []byte) bool {
+		err = targetDevice.StartScreenCapture(screencaptureFormat, devices.DefaultMJPEGQuality, devices.DefaultMJPEGScale, func(data []byte) bool {
 			_, writeErr := os.Stdout.Write(data)
 			if writeErr != nil {
 				fmt.Fprintf(os.Stderr, "Error writing data: %v\n", writeErr)

commands/screencapture.go

@@ -1,6 +1,8 @@
 package commands
 
 type ScreenCaptureRequest struct {
-	DeviceID string `json:"deviceId"`
-	Format   string `json:"format"`
+	DeviceID string  `json:"deviceId"`
+	Format   string  `json:"format"`
+	Quality  int     `json:"quality,omitempty"`
+	Scale    float64 `json:"scale,omitempty"`
 }

devices/android.go

@@ -325,7 +325,7 @@ func (d AndroidDevice) GetAppPath(packageName string) (string, error) {
 	return appPath, nil
 }
 
-func (d AndroidDevice) StartScreenCapture(format string, callback func([]byte) bool) error {
+func (d AndroidDevice) StartScreenCapture(format string, quality int, scale float64, callback func([]byte) bool) error {
 	if format != "mjpeg" {
 		return fmt.Errorf("unsupported format: %s, only 'mjpeg' is supported", format)
 	}
@@ -342,7 +342,7 @@ func (d AndroidDevice) StartScreenCapture(format string, callback func([]byte) b
 	}
 
 	utils.Verbose("Starting MJPEG server with app path: %s", appPath)
-	cmdArgs := append([]string{"-s", d.id}, "shell", fmt.Sprintf("CLASSPATH=%s", appPath), "app_process", "/system/bin", "com.mobilenext.devicekit.MjpegServer")
+	cmdArgs := append([]string{"-s", d.id}, "shell", fmt.Sprintf("CLASSPATH=%s", appPath), "app_process", "/system/bin", "com.mobilenext.devicekit.MjpegServer", "--quality", fmt.Sprintf("%d", quality), "--scale", fmt.Sprintf("%.2f", scale))
 	cmd := exec.Command(getAdbPath(), cmdArgs...)
 
 	stdout, err := cmd.StdoutPipe()

devices/common.go

@@ -7,6 +7,13 @@ import (
 	"github.com/mobile-next/mobilecli/utils"
 )
 
+const (
+	// Default MJPEG streaming quality (1-100)
+	DefaultMJPEGQuality = 80
+	// Default MJPEG streaming scale (0.1-1.0)
+	DefaultMJPEGScale = 1.0
+)
+
 type ControllableDevice interface {
 	ID() string
 	Name() string
@@ -25,7 +32,7 @@ type ControllableDevice interface {
 	OpenURL(url string) error
 	ListApps() ([]InstalledAppInfo, error)
 	Info() (*FullDeviceInfo, error)
-	StartScreenCapture(format string, callback func([]byte) bool) error
+	StartScreenCapture(format string, quality int, scale float64, callback func([]byte) bool) error
 }
 
 // GetAllControllableDevices aggregates all known devices (iOS, Android, Simulators)

devices/ios.go

@@ -546,7 +546,7 @@ func (d IOSDevice) Info() (*FullDeviceInfo, error) {
 	}, nil
 }
 
-func (d IOSDevice) StartScreenCapture(format string, callback func([]byte) bool) error {
+func (d IOSDevice) StartScreenCapture(format string, quality int, scale float64, callback func([]byte) bool) error {
 	return d.mjpegClient.StartScreenCapture(format, callback)
 }
 

devices/simulator.go

@@ -403,7 +403,7 @@ func (s Simulator) Info() (*FullDeviceInfo, error) {
 	}, nil
 }
 
-func (s Simulator) StartScreenCapture(format string, callback func([]byte) bool) error {
+func (s Simulator) StartScreenCapture(format string, quality int, scale float64, callback func([]byte) bool) error {
 	mjpegClient := mjpeg.NewWdaMjpegClient("http://localhost:9100")
 	return mjpegClient.StartScreenCapture(format, callback)
 }

server/server.go

@@ -10,6 +10,7 @@ import (
 	"time"
 
 	"github.com/mobile-next/mobilecli/commands"
+	"github.com/mobile-next/mobilecli/devices"
 )
 
 const (
@@ -429,6 +430,17 @@ func handleScreenCapture(w http.ResponseWriter, params json.RawMessage) error {
 		return fmt.Errorf("format must be 'mjpeg' for screen capture")
 	}
 
+	// Set defaults if not provided
+	quality := screenCaptureParams.Quality
+	if quality == 0 {
+		quality = devices.DefaultMJPEGQuality
+	}
+
+	scale := screenCaptureParams.Scale
+	if scale == 0.0 {
+		scale = devices.DefaultMJPEGScale
+	}
+
 	err = targetDevice.StartAgent()
 	if err != nil {
 		return fmt.Errorf("error starting agent: %v", err)
@@ -441,7 +453,7 @@ func handleScreenCapture(w http.ResponseWriter, params json.RawMessage) error {
 	w.Header().Set("Transfer-Encoding", "chunked")
 
 	// Start screen capture and stream to the response writer
-	err = targetDevice.StartScreenCapture(screenCaptureParams.Format, func(data []byte) bool {
+	err = targetDevice.StartScreenCapture(screenCaptureParams.Format, quality, scale, func(data []byte) bool {
 		_, writeErr := w.Write(data)
 		if writeErr != nil {
 			fmt.Println("Error writing data:", writeErr)