Skip to content

Memory leak with observer  #16

@jsaunderson

Description

@jsaunderson

There is a memory leak when using an observer, this appears to be caused by mixinLifecycleEvents not patching componentWillUnmount resulting in the reaction never being disposed.

After adding patch(target, 'componentWillUnmount'); the memory leak went away.

Is there any reason it was omitted, or can it be added in?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions