-
-
Notifications
You must be signed in to change notification settings - Fork 52
Open
Labels
Description
deserialize uses node-style callbacks, but fails to follow the rule "callback is the last argument". This prevents making use of util.promisify, which
Takes a function following the common error-first callback style, i.e. taking a
(err, value) => ...callback as the last argument, and returns a version that returns promises.
I suggest moving callback to the end of argument list. This would also be more convenient: now you have to pass null for the callback in cases when you don't need async deserialization, but have to pass custom args.
Reactions are currently unavailable