Skip to content

Commit f1aa086

Browse files
authored
Merge pull request #1473 from mrjana/agent
Avoid returning early on agent join failures
2 parents bf3d9cc + 23a782b commit f1aa086

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

agent.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -191,8 +191,7 @@ func (c *controller) agentSetup() error {
191191

192192
if remoteAddr != "" {
193193
if err := c.agentJoin(remoteAddr); err != nil {
194-
logrus.Errorf("Error in agentJoin : %v", err)
195-
return nil
194+
logrus.Errorf("Error in joining gossip cluster : %v(join will be retried in background)", err)
196195
}
197196
}
198197

networkdb/cluster.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,10 @@ func (nDB *NetworkDB) retryJoin(members []string, stop <-chan struct{}) {
161161
logrus.Errorf("Failed to join memberlist %s on retry: %v", members, err)
162162
continue
163163
}
164+
if err := nDB.sendNodeEvent(NodeEventTypeJoin); err != nil {
165+
logrus.Errorf("failed to send node join on retry: %v", err)
166+
continue
167+
}
164168
return
165169
case <-stop:
166170
return

0 commit comments

Comments
 (0)