fix(deps): update chokidar to v4 (#5256)

* chore(deps): update choikdar to v4

* chore: resolve comment issues

* fix: prevent traversing ignored directories

* Remove unnecessary line

Co-authored-by: Josh Goldberg ✨ <[email protected]>

* chore: update lock file

---------

Co-authored-by: Josh Goldberg ✨ <[email protected]>

Author: ggodlewski

lib/cli/watch-run.js

@@ -6,6 +6,7 @@ const path = require('node:path');
 const chokidar = require('chokidar');
 const Context = require('../context');
 const collectFiles = require('./collect-files');
+const glob = require('glob');
 
 /**
  * Exports the `watchRun` function that runs mocha in "watch" mode.
@@ -136,6 +137,42 @@ exports.watchRun = (mocha, {watchFiles, watchIgnore}, fileCollectParams) => {
   });
 };
 
+class GlobFilesTracker {
+  constructor(watchFiles, watchIgnore) {
+    this.watchFilesSet = new Set();
+    this.watchFiles = watchFiles;
+    this.watchIgnore = watchIgnore;
+  }
+
+  regenerate() {
+    const watchIgnoreSet = new Set();
+    for (const pattern of this.watchIgnore) {
+      glob.sync(pattern, { dot: true }).forEach(filePath => watchIgnoreSet.add(filePath));
+    }
+
+    const globOpts = {
+      dot: true,
+      ignore: {
+        childrenIgnored: pathToCheck => watchIgnoreSet.has(pathToCheck.relative())
+      }
+    };
+
+    this.watchFilesSet.clear();
+    for (const pattern of this.watchFiles) {
+      glob.sync(pattern, globOpts).forEach(pathToCheck => {
+        if (watchIgnoreSet.has(pathToCheck)) {
+          return;
+        }
+        this.watchFilesSet.add(pathToCheck);
+      });
+    }
+  }
+
+  has(filePath) {
+    return this.watchFilesSet.has(filePath)
+  }
+}
+
 /**
  * Bootstraps a chokidar watcher. Handles keyboard input & signals
  * @param {Mocha} mocha - Mocha instance
@@ -167,8 +204,10 @@ const createWatcher = (
   // we handle global fixtures manually
   mocha.enableGlobalSetup(false).enableGlobalTeardown(false);
 
-  const watcher = chokidar.watch(watchFiles, {
-    ignored: watchIgnore,
+  const tracker = new GlobFilesTracker(watchFiles, watchIgnore);
+  tracker.regenerate();
+
+  const watcher = chokidar.watch('.', {
     ignoreInitial: true
   });
 
@@ -184,8 +223,13 @@ const createWatcher = (
     rerunner.run();
   });
 
-  watcher.on('all', () => {
-    rerunner.scheduleRun();
+  watcher.on('all', (event, filePath) => {
+    if (event === 'add') {
+      tracker.regenerate();
+    }
+    if (tracker.has(filePath)) {
+      rerunner.scheduleRun();
+    }
   });
 
   hideCursor();