feat!: change the default of --forbid-only to check for process.env.CI.

Fixes #5299

Author: RobinVdBroeck

docs/index.md

@@ -947,6 +947,12 @@ Enforce a rule that tests may not be exclusive (use of e.g., `describe.only()` o
 
 `--forbid-only` causes Mocha to fail when an exclusive ("only'd") test or suite is encountered, and it will abort further test execution.
 
+Defaults:
+
+1. Before v12: false
+2. After v12: false, unless an environment variable called `CI` is set. Many popular
+   CI providers, like github actions or gitlab, do this automatically.
+
 ### `--forbid-pending`
 
 Enforce a rule that tests may not be skipped (use of e.g., `describe.skip()`, `it.skip()`, or `this.skip()` anywhere is disallowed).

lib/cli/run.js

@@ -123,7 +123,8 @@ exports.builder = yargs =>
       },
       'forbid-only': {
         description: 'Fail if exclusive test(s) encountered',
-        group: GROUPS.RULES
+        group: GROUPS.RULES,
+        default: !!process.env.CI,
       },
       'forbid-pending': {
         description: 'Fail if pending test(s) encountered',

package.json

@@ -71,7 +71,7 @@
     "test-browser": "run-s clean build test-browser:*",
     "test-coverage-clean": "rimraf .nyc_output coverage",
     "test-coverage-generate": "nyc report --reporter=lcov --reporter=text",
-    "test-node-run-only": "nyc --no-clean --reporter=json node bin/mocha.js",
+    "test-node-run-only": "nyc --no-clean --reporter=json node bin/mocha.js --no-forbid-only",
     "test-node-run": "nyc --no-clean --reporter=json node bin/mocha.js --forbid-only",
     "test-node:integration": "run-s clean build && npm run -s test-node-run -- --parallel --timeout 10000 --slow 3750 \"test/integration/**/*.spec.js\"",
     "test-node:integration:watch": "run-s clean build && npm run -s test-node-run -- --parallel --timeout 10000 --slow 3750 \"test/integration/options/watch.spec.js\"",

test/integration/common-js-require.spec.js

@@ -5,7 +5,8 @@ const {runMochaAsync} = require('./helpers');
 describe('common js require', () => {
   it('should be able to run a test where all mocha exports are used', async () => {
     const result = await runMochaAsync('common-js-require.fixture.js', [
-      '--delay'
+      '--delay',
+      '--no-forbid-only'
     ]);
     expect(result.output, 'to contain', 'running before');
     expect(result.output, 'to contain', 'running suiteSetup');

test/integration/only.spec.js

@@ -6,7 +6,7 @@ var assert = require('node:assert');
 describe('.only()', function () {
   describe('bdd', function () {
     it('should run only tests that marked as `only`', function (done) {
-      run('options/only/bdd.fixture.js', ['--ui', 'bdd'], function (err, res) {
+      run('options/only/bdd.fixture.js', ['--ui', 'bdd', '--no-forbid-only'], function (err, res) {
         if (err) {
           done(err);
           return;
@@ -22,7 +22,7 @@ describe('.only()', function () {
 
   describe('tdd', function () {
     it('should run only tests that marked as `only`', function (done) {
-      run('options/only/tdd.fixture.js', ['--ui', 'tdd'], function (err, res) {
+      run('options/only/tdd.fixture.js', ['--ui', 'tdd', '--no-forbid-only'], function (err, res) {
         if (err) {
           done(err);
           return;
@@ -40,7 +40,7 @@ describe('.only()', function () {
     it('should run only tests that marked as `only`', function (done) {
       run(
         'options/only/qunit.fixture.js',
-        ['--ui', 'qunit'],
+        ['--ui', 'qunit', '--no-forbid-only'],
         function (err, res) {
           if (err) {
             done(err);

test/integration/options/delay.spec.js

@@ -5,11 +5,7 @@ var helpers = require('../helpers');
 var runMochaJSON = helpers.runMochaJSON;
 
 describe('--delay', function () {
-  var args = [];
-
-  before(function () {
-    args = ['--delay'];
-  });
+  var args = ['--delay', '--no-forbid-only'];
 
   it('should run the generated test suite', function (done) {
     var fixture = path.join('options', 'delay');

test/integration/options/dryRun.spec.js

@@ -5,7 +5,7 @@ var helpers = require('../helpers');
 var runMochaJSON = helpers.runMochaJSON;
 
 describe('--dry-run', function () {
-  var args = ['--dry-run'];
+  var args = ['--dry-run', '--no-forbid-only'];
 
   it('should only report, but not execute any test', function (done) {
     var fixture = path.join('options/dry-run', 'dry-run');

test/integration/regression.spec.js

@@ -51,7 +51,7 @@ describe('regressions', function () {
   });
 
   it('issue-2406: should run nested describe.only suites', function (done) {
-    runJSON('regression/issue-2406.fixture.js', [], function (err, res) {
+    runJSON('regression/issue-2406.fixture.js', ['--no-forbid-only'], function (err, res) {
       if (err) {
         done(err);
         return;
@@ -64,7 +64,7 @@ describe('regressions', function () {
   });
 
   it('issue-2417: should not recurse infinitely with .only suites nested within each other', function (done) {
-    runJSON('regression/issue-2417.fixture.js', [], function (err, res) {
+    runJSON('regression/issue-2417.fixture.js', ['--no-forbid-only'], function (err, res) {
       if (err) {
         done(err);
         return;