fix: allow FIFOs as test files #5512
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5512 +/- ##
=======================================
Coverage 93.68% 93.68%
=======================================
Files 57 57
Lines 4384 4384
Branches 846 846
=======================================
Hits 4107 4107
Misses 277 277 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thanks @alxndrsn, looks like this is a new feature, not a fix? Or did this behavior exist before and was lost? Regardless, can you add a unit test to cover this scenario? |
mark-wiemer
requested changes
Nov 1, 2025
Member
mark-wiemer
left a comment
mark-wiemer
left a comment
There was a problem hiding this comment.
Thanks again, here's the remaining work in my view:
- add test
- sign CLA
- resolve lint issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5511
PR Checklist
status: accepting prsOverview
Support running tests from FIFOs.