Cleanup scrollbar event handlers after unmounting

mtsgrd · mtsgrd · commit 9af0e4bbaa84 · 2025-05-22T19:41:26.000+02:00
diff --git a/packages/ui/src/lib/scroll/Scrollbar.svelte b/packages/ui/src/lib/scroll/Scrollbar.svelte
@@ -38,15 +38,19 @@
 
 	$effect(() => {
 		if (viewport) {
-			setupViewport(viewport);
+			return setupViewport(viewport);
 		}
+	});
 
+	$effect(() => {
 		if (thumb) {
-			setupThumb(thumb);
+			return setupThumb(thumb);
 		}
+	});
 
+	$effect(() => {
 		if (track) {
-			setupTrack(track);
+			return setupTrack(track);
 		}
 	});
 

Original file line number	Diff line number	Diff line change
`@@ -38,15 +38,19 @@`
`38`	`38`
`39`	`39`	`$effect(() => {`
`40`	`40`	`if (viewport) {`
`41`		`- setupViewport(viewport);`
	`41`	`+ return setupViewport(viewport);`
`42`	`42`	`}`
	`43`	`+ });`
`43`	`44`
	`45`	`+ $effect(() => {`
`44`	`46`	`if (thumb) {`
`45`		`- setupThumb(thumb);`
	`47`	`+ return setupThumb(thumb);`
`46`	`48`	`}`
	`49`	`+ });`
`47`	`50`
	`51`	`+ $effect(() => {`
`48`	`52`	`if (track) {`
`49`		`- setupTrack(track);`
	`53`	`+ return setupTrack(track);`
`50`	`54`	`}`
`51`	`55`	`});`
`52`	`56`