Merge pull request #155 from mockingbot/manage-native-deps-with-cocoapods

Manage native deps with cocoapods

Author: plrthink

.eslintrc

@@ -2,9 +2,5 @@
   "extends": [
     "standard",
     "plugin:react/recommended"
-  ],
-  "plugins": ["jest"],
-  "env": {
-    "jest/globals": true
-  }
+  ]
 }

README.md

@@ -1,132 +1,34 @@
-# React Native Zip Archive [![npm](https://img.shields.io/npm/dm/react-native-zip-archive.svg)](https://www.npmjs.com/package/react-native-zip-archive) [![npm](https://img.shields.io/npm/v/react-native-zip-archive.svg)](https://www.npmjs.com/package/react-native-zip-archive)
+# React Native Zip Archive [![npm](https://img.shields.io/npm/v/react-native-zip-archive.svg)](https://www.npmjs.com/package/react-native-zip-archive)
 
 Zip archive utility for react-native
 
-# IMPORTANT
 
-For react-native < 0.58, use [email protected]
-For react-native >= 0.58, use [email protected]
+## Compatibility
+
+| react-native version | react-native-zip-archive version |
+| --- | --- |
+| ^0.60 | ^5.0.0 |
+| ^0.58 | ^4.0.0 |
+| <0.58 | ^3.0.0 |
+
 
 ## Installation
 
 ```bash
 npm install react-native-zip-archive --save
 ```
 
+
 ## Linking
 
-### Automatically (Recommend)
+For iOS, run the command below in you app's root folder once the package has been installed
 
 ````bash
-react-native link react-native-zip-archive
+cd ./ios && pod install
 ````
 
-### Manually
-
-#### iOS
-
-refer to the [official guide](https://facebook.github.io/react-native/docs/linking-libraries-ios.html),
-remember to also link `libz`, `libiconv` and `Security` to your target.(You can follow the tutorial on [this](http://docs.onemobilesdk.aol.com/ios-ad-sdk/adding-frameworks-xcode.html))
-
-#### Android
-
-* Edit `android/settings.gradle` to look like this (without the +):
-
-  ```diff
-  rootProject.name = 'MyApp'
-
-  include ':app'
-
-  + include ':react-native-zip-archive'
-  + project(':react-native-zip-archive').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-zip-archive/android')
-  ```
-
-* Edit `android/app/build.gradle` (note: **app** folder) to look like this:
-
-  ```diff
-  apply plugin: 'com.android.application'
-
-  android {
-    ...
-  }
-
-  dependencies {
-    compile fileTree(dir: 'libs', include: ['*.jar'])
-    compile 'com.android.support:appcompat-v7:23.0.0'
-    compile 'com.facebook.react:react-native:0.16.+'
-  + compile project(':react-native-zip-archive')
-  }
-  ```
-
-* For react-native blew 0.19.0
-  - Edit your `MainActivity.java` (deep in `android/app/src/main/java/...`) to look like this (note **two** places to edit):
-
-  ```diff
-  + import import com.rnziparchive.RNZipArchivePackage;
-
-  ....
+For Andriod, it's ready to go.
 
-    @Override
-    protected void onCreate(Bundle savedInstanceState) {
-      super.onCreate(savedInstanceState);
-      mReactRootView = new ReactRootView(this);
-
-      mReactInstanceManager = ReactInstanceManager.builder()
-        .setApplication(getApplication())
-        .setBundleAssetName("index.android.bundle")
-        .setJSMainModuleName("index.android")
-        .addPackage(new MainReactPackage())
-  +     .addPackage(new RNZipArchivePackage())
-        .setUseDeveloperSupport(BuildConfig.DEBUG)
-        .setInitialLifecycleState(LifecycleState.RESUMED)
-        .build();
-
-      mReactRootView.startReactApplication(mReactInstanceManager, "ExampleRN", null);
-
-      setContentView(mReactRootView);
-    }
-  ```
-
-* react-native 0.19.0 and higher
-
-  - Edit your `MainActivity.java` (deep in `android/app/src/main/java/...`) to look like this (note **two** places to edit):
-
-  ```diff
-  package com.myapp;
-
-  + import com.rnziparchive.RNZipArchivePackage;
-
-  ....
-
-    @Override
-    protected List<ReactPackage> getPackages() {
-      return Arrays.<ReactPackage>asList(
-        new MainReactPackage(),
-  +     new RNZipArchivePackage()
-      );
-    }
-
-  }
-  ```
-
-* For react-native 0.29.0 and higher ( in MainApplication.java )
-
-  - Edit your `MainApplication.java` (deep in `android/app/src/main/java/...`) to look like this (note **three** places to edit):
-
-  ```diff
-  + import com.rnziparchive.RNZipArchivePackage;
-
-  public class MainApplication extends Application implements ReactApplication {
-    ...
-      @Override
-      protected List<ReactPackage> getPackages() {
-        return Arrays.<ReactPackage>asList(
-  -       new MainReactPackage()
-  +       new MainReactPackage(),
-  +       new RNZipArchivePackage()
-        );
-      }
-  ```
 
 ## Usage
 
@@ -142,9 +44,10 @@ you may also want to use something like [react-native-fs](https://github.com/joh
 import { MainBundlePath, DocumentDirectoryPath } from 'react-native-fs'
 ```
 
+
 ## API
 
-**zip(source: string, target: string): Promise**
+**`zip(source: string, target: string): Promise<string>`**
 
 > zip source to target
 
@@ -163,7 +66,7 @@ zip(sourcePath, targetPath)
 })
 ```
 
-**zipWithPassword(source: string, target: string, password: string, encryptionType: string): Promise**
+**`zipWithPassword(source: string, target: string, password: string, encryptionType: string): Promise<string>`**
 
 > zip source to target
 
@@ -195,7 +98,7 @@ Example
 ```js
 const sourcePath = `${DocumentDirectoryPath}/myFile.zip`
 const targetPath = DocumentDirectoryPath
-const charset = 'UTF-8' 
+const charset = 'UTF-8'
 // charset possible values: UTF-8, GBK, US-ASCII and so on. If none was passed, default value is UTF-8
 
 
@@ -208,7 +111,7 @@ unzip(sourcePath, targetPath, charset)
 })
 ```
 
-**unzipWithPassword(source: string, target: string, password: string): Promise**
+**`unzipWithPassword(source: string, target: string, password: string): Promise<string>`**
 
 > unzip from source to target
 
@@ -228,7 +131,7 @@ unzipWithPassword(sourcePath, targetPath, password)
 })
 ```
 
-**unzipAssets(assetPath: string, target: string): Promise**
+**`unzipAssets(assetPath: string, target: string): Promise<string>`**
 
 > unzip file from Android `assets` folder to target path
 
@@ -237,7 +140,7 @@ unzipWithPassword(sourcePath, targetPath, password)
 `assetPath` is the relative path to the file inside the pre-bundled assets folder, e.g. `folder/myFile.zip`. ***Do not pass an absolute directory.***
 
 ```js
-const assetPath = `${DocumentDirectoryPath}/myFile.zip`
+const assetPath = './myFile.zip'
 const targetPath = DocumentDirectoryPath
 
 unzipAssets(assetPath, targetPath)
@@ -249,7 +152,7 @@ unzipAssets(assetPath, targetPath)
 })
 ```
 
-**subscribe(callback: ({ progress: number, filePath: string })): EmitterSubscription**
+**`subscribe(callback: ({ progress: number, filePath: string }) => void): EmitterSubscription`**
 
 > Subscribe to the progress callbacks. Useful for displaying a progress bar on your UI during the process.
 
@@ -276,6 +179,8 @@ componentWillUnmount() {
 }
 ```
 
+
 ## Related Projects
 
 - [ZipArchive](https://github.com/ZipArchive/ZipArchive)
+- [zip4j](https://github.com/srikanth-lingala/zip4j)

RNZipArchive.podspec

@@ -3,7 +3,6 @@ require 'json'
 package = JSON.parse(File.read(File.join(__dir__, 'package.json')))
 
 Pod::Spec.new do |s|
-
   s.name           = 'RNZipArchive'
   s.version        = package['version']
   s.summary        = package['description']
@@ -13,14 +12,13 @@ Pod::Spec.new do |s|
   s.source         = { :git => 'https://github.com/mockingbot/react-native-zip-archive.git', :tag => "#{s.version}"}
   s.platform       = :ios, '8.0'
   s.preserve_paths = '*.js'
-  s.library        = 'z'
 
   s.dependency 'React'
   s.dependency 'SSZipArchive', '2.2.2'
+  s.compiler_flags = '-GCC_PREPROCESSOR_DEFINITIONS="HAVE_INTTYPES_H HAVE_PKCRYPT HAVE_STDINT_H HAVE_WZAES HAVE_ZLIB MZ_ZIP_NO_SIGNING $(inherited)"'
 
   s.subspec 'Core' do |ss|
     ss.source_files = 'ios/*.{h,m}'
     ss.public_header_files = ['ios/RNZipArchive.h']
   end
-
 end

example/.eslintrc.js

@@ -0,0 +1,4 @@
+module.exports = {
+  root: true,
+  extends: '@react-native-community',
+};

example/.flowconfig

@@ -11,60 +11,66 @@
 ; Ignore duplicate module providers
 ; For RN Apps installed via npm, "Libraries" folder is inside
 ; "node_modules/react-native" but in the source repo it is in the root
-.*/Libraries/react-native/React.js
-
+node_modules/react-native/Libraries/react-native/React.js
 ; Ignore polyfills
-.*/Libraries/polyfills/.*
-
-; Ignore metro
-.*/node_modules/metro/.*
-
+node_modules/react-native/Libraries/polyfills/.*
+; These should not be required directly
+; require from fbjs/lib instead: require('fbjs/lib/warning')
+node_modules/warning/.*
+; Flow doesn't support platforms
+.*/Libraries/Utilities/HMRLoadingView.js
+[untyped]
+.*/node_modules/@react-native-community/cli/.*/.*
 [include]
-
 [libs]
 node_modules/react-native/Libraries/react-native/react-native-interface.js
 node_modules/react-native/flow/
-node_modules/react-native/flow-github/
-
 [options]
 emoji=true
-
 esproposal.optional_chaining=enable
 esproposal.nullish_coalescing=enable
-
+module.file_ext=.js
+module.file_ext=.json
+module.file_ext=.ios.js
 module.system=haste
 module.system.haste.use_name_reducers=true
 # get basename
-module.system.haste.name_reducers='^.*/\([a-zA-Z0-9$_.-]+\.js\(\.flow\)?\)$' -> '\1'
-# strip .js or .js.flow suffix
-module.system.haste.name_reducers='^\(.*\)\.js\(\.flow\)?$' -> '\1'
-# strip .ios suffix
-module.system.haste.name_reducers='^\(.*\)\.ios$' -> '\1'
-module.system.haste.name_reducers='^\(.*\)\.android$' -> '\1'
 module.system.haste.name_reducers='^\(.*\)\.native$' -> '\1'
 module.system.haste.paths.blacklist=.*/__tests__/.*
 module.system.haste.paths.blacklist=.*/__mocks__/.*
-module.system.haste.paths.blacklist=<PROJECT_ROOT>/node_modules/react-native/Libraries/Animated/src/polyfills/.*
 module.system.haste.paths.whitelist=<PROJECT_ROOT>/node_modules/react-native/Libraries/.*
-
+module.system.haste.paths.whitelist=<PROJECT_ROOT>/node_modules/react-native/RNTester/.*
+module.system.haste.paths.whitelist=<PROJECT_ROOT>/node_modules/react-native/IntegrationTests/.*
+module.system.haste.paths.blacklist=<PROJECT_ROOT>/node_modules/react-native/Libraries/react-native/react-native-implementation.js
+module.system.haste.paths.blacklist=<PROJECT_ROOT>/node_modules/react-native/Libraries/Animated/src/polyfills/.*
 munge_underscores=true
-
 module.name_mapper='^[./a-zA-Z0-9$_-]+\.\(bmp\|gif\|jpg\|jpeg\|png\|psd\|svg\|webp\|m4v\|mov\|mp4\|mpeg\|mpg\|webm\|aac\|aiff\|caf\|m4a\|mp3\|wav\|html\|pdf\)$' -> 'RelativeImageStub'
-
-module.file_ext=.js
-module.file_ext=.jsx
-module.file_ext=.json
-module.file_ext=.native.js
-
 suppress_type=$FlowIssue
 suppress_type=$FlowFixMe
 suppress_type=$FlowFixMeProps
 suppress_type=$FlowFixMeState
-
-suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(<VERSION>\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)
-suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(<VERSION>\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)?:? #[0-9]+
-suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
+suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(<VERSION>\\)? *\\(site=[a-z,_]*react_native\\(_ios\\)?_\\(oss\\|fb\\)[a-z,_]*\\)?)\\)
+suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(<VERSION>\\)? *\\(site=[a-z,_]*react_native\\(_ios\\)?_\\(oss\\|fb\\)[a-z,_]*\\)?)\\)?:? #[0-9]+
 suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError
-
+[lints]
+sketchy-null-number=warn
+sketchy-null-mixed=warn
+sketchy-number=warn
+untyped-type-import=warn
+nonstrict-import=warn
+deprecated-type=warn
+unsafe-getters-setters=warn
+inexact-spread=warn
+unnecessary-invariant=warn
+signature-verification-failure=warn
+deprecated-utility=error
+[strict]
+deprecated-type
+nonstrict-import
+sketchy-null
+unclear-type
+unsafe-getters-setters
+untyped-import
+untyped-type-import
 [version]
-^0.86.0
+^0.98.0

example/.gitignore

@@ -54,3 +54,6 @@ buck-out/
 
 # Bundle artifact
 *.jsbundle
+
+# CocoaPods
+/ios/Pods/

example/Example.js

@@ -1,8 +1,9 @@
 import React, { Component } from 'react'
 import {
   StyleSheet, View,
-  Alert, WebView, Platform
+  Alert, Platform
 } from 'react-native'
+import WebView from 'react-native-webview'
 import {
   ANIMATIONS_SLIDE,
   CustomTabs

example/__tests__/App.js

@@ -1,6 +1,5 @@
 /**
  * @format
- * @lint-ignore-every XPLATJSCOPYRIGHT1
  */
 
 import 'react-native';