Port groups

Squashed commit of the following:

commit 3b2e3a0
Author: falkTX <[email protected]>
Date:   Sat Oct 18 13:48:38 2025 +0200

    Cleanup

    Signed-off-by: falkTX <[email protected]>

commit 2b46a5e
Author: Andrea Del Signore <[email protected]>
Date:   Thu Oct 16 17:40:33 2025 +0200

    Update python binding to cpp utils in order to support port groups

commit f05f891
Author: Andrea Del Signore <[email protected]>
Date:   Thu Oct 16 17:34:27 2025 +0200

    Add support for lv2 group extension to lilv backend

Signed-off-by: falkTX <[email protected]>

Author: falkTX

modtools/utils.py

@@ -221,6 +221,13 @@ class PluginGUI_Mini(Structure):
         ("thumbnail", c_char_p),
     ]
 
+class PluginPortGroup(Structure):
+    _fields_ = [
+        ("valid", c_bool),
+        ("symbol", c_char_p),
+        ("name", c_char_p),
+    ]
+
 class PluginPortRanges(Structure):
     _fields_ = [
         ("minimum", c_float),
@@ -253,6 +260,7 @@ class PluginPort(Structure):
         ("units", PluginPortUnits),
         ("comment", c_char_p),
         ("designation", c_char_p),
+        ("group", c_char_p),
         ("properties", POINTER(c_char_p)),
         ("rangeSteps", c_int),
         ("scalePoints", POINTER(PluginPortScalePoint)),
@@ -343,6 +351,7 @@ class PluginInfo(Structure):
         ("bundles", POINTER(c_char_p)),
         ("gui", PluginGUI),
         ("ports", PluginPorts),
+        ("portGroups", POINTER(PluginPortGroup)),
         ("parameters", POINTER(PluginParameter)),
         ("presets", POINTER(PluginPreset)),
     ]
@@ -532,6 +541,7 @@ class JackData(Structure):
                    POINTER(PluginPortScalePoint),
                    POINTER(PluginPort),
                    POINTER(PluginParameter),
+                   POINTER(PluginPortGroup),
                    POINTER(PluginPreset),
                    POINTER(PedalboardPlugin),
                    POINTER(PedalboardConnection),

utils/utils.h

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2012-2023 MOD Audio UG
+// SPDX-FileCopyrightText: 2012-2025 MOD Audio UG
 // SPDX-License-Identifier: AGPL-3.0-or-later
 
 #ifndef MOD_UTILS_H_INCLUDED
@@ -76,6 +76,13 @@ typedef struct {
     const char* thumbnail;
 } PluginGUI_Mini;
 
+typedef struct {
+    bool valid;
+    const char* uri;
+    const char* symbol;
+    const char* name;
+} PluginPortGroup;
+
 typedef struct {
     float min;
     float max;
@@ -104,6 +111,7 @@ typedef struct {
     PluginPortUnits units;
     const char* comment;
     const char* designation;
+    const char* group;
     const char* const* properties;
     int rangeSteps;
     const PluginPortScalePoint* scalePoints;
@@ -185,6 +193,7 @@ typedef struct {
     const char* const* bundles;
     PluginGUI gui;
     PluginPorts ports;
+    const PluginPortGroup* portGroups;
     const PluginParameter* parameters;
     const PluginPreset* presets;
 } PluginInfo;

utils/utils_lilv.cpp

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2012-2023 MOD Audio UG
+// SPDX-FileCopyrightText: 2012-2025 MOD Audio UG
 // SPDX-License-Identifier: AGPL-3.0-or-later
 
 #include "utils.h"
@@ -15,6 +15,7 @@
 #include <lv2/midi/midi.h>
 #include <lv2/morph/morph.h>
 #include <lv2/patch/patch.h>
+#include <lv2/port-groups/port-groups.h>
 #include <lv2/port-props/port-props.h>
 #include <lv2/presets/presets.h>
 #include <lv2/state/state.h>
@@ -210,6 +211,7 @@ static const bool kOnlyShowPluginsWithMODGUI = getenv("MOD_UI_ONLY_SHOW_PLUGINS_
         { nullptr, nullptr }                         \
     },                                               \
     nullptr,                                         \
+    nullptr,                                         \
     nullptr                                          \
 }
 
@@ -358,6 +360,7 @@ struct NamespaceDefinitions {
     LilvNode* atom_bufferType;
     LilvNode* atom_Sequence;
     LilvNode* midi_MidiEvent;
+    LilvNode* pgroups_group;
     LilvNode* pprops_rangeSteps;
     LilvNode* patch_readable;
     LilvNode* patch_writable;
@@ -451,6 +454,7 @@ struct NamespaceDefinitions {
         atom_bufferType          = lilv_new_uri(w, LV2_ATOM__bufferType);
         atom_Sequence            = lilv_new_uri(w, LV2_ATOM__Sequence);
         midi_MidiEvent           = lilv_new_uri(w, LV2_MIDI__MidiEvent);
+        pgroups_group            = lilv_new_uri(w, LV2_PORT_GROUPS__group);
         pprops_rangeSteps        = lilv_new_uri(w, LV2_PORT_PROPS__rangeSteps);
         patch_readable           = lilv_new_uri(w, LV2_PATCH__readable);
         patch_writable           = lilv_new_uri(w, LV2_PATCH__writable);
@@ -522,6 +526,7 @@ struct NamespaceDefinitions {
         lilv_node_free(atom_bufferType);
         lilv_node_free(atom_Sequence);
         lilv_node_free(midi_MidiEvent);
+        lilv_node_free(pgroups_group);
         lilv_node_free(pprops_rangeSteps);
         lilv_node_free(patch_readable);
         lilv_node_free(patch_writable);
@@ -2605,6 +2610,8 @@ const PluginInfo& _get_plugin_info(LilvWorld* const w,
     // --------------------------------------------------------------------------------------------------------
     // ports
 
+    std::unordered_map<std::string, PluginPortGroup> portGroups;
+
     if (const uint32_t count = lilv_plugin_get_num_ports(p))
     {
         uint32_t countAudioInput=0,   countAudioOutput=0;
@@ -2851,6 +2858,47 @@ const PluginInfo& _get_plugin_info(LilvWorld* const w,
                 portinfo.designation = nc;
             }
 
+            // ----------------------------------------------------------------------------------------------------
+            // group
+
+            if (LilvNodes* const nodes = lilv_port_get_value(p, port, ns.pgroups_group))
+            {
+                LilvNode* const group = lilv_nodes_get_first(nodes);
+                portinfo.group = strdup(lilv_node_as_string(group));
+
+                if (! contains(portGroups, portinfo.group))
+                {
+                    PluginPortGroup& portGroup = portGroups[portinfo.group] = {
+                        true,
+                        portinfo.group,
+                        nc,
+                        nc,
+                    };
+
+                    if (LilvNode* const group_symbol = lilv_world_get(w, group, ns.lv2core_symbol, nullptr))
+                    {
+                        if (const char* const symbolstr = lilv_node_as_string(group_symbol))
+                            portGroup.symbol = strdup(symbolstr);
+
+                        lilv_node_free(group_symbol);
+                    }
+
+                    if (LilvNode* const group_name = lilv_world_get(w, group, ns.lv2core_name, nullptr))
+                    {
+                        if (const char* const namestr = lilv_node_as_string(group_name))
+                            portGroup.symbol = strdup(namestr);
+
+                        lilv_node_free(group_name);
+                    }
+                }
+
+                lilv_nodes_free(nodes);
+            }
+            else
+            {
+                portinfo.group = nc;
+            }
+
             // ----------------------------------------------------------------------------------------------------
             // range steps
 
@@ -3069,6 +3117,22 @@ const PluginInfo& _get_plugin_info(LilvWorld* const w,
         info.iotype = kPluginIONull;
     }
 
+    // --------------------------------------------------------------------------------------------------------
+    // port groups
+
+    if (size_t count = portGroups.size())
+    {
+        PluginPortGroup* const groups = new PluginPortGroup[count+1];
+
+        count = 0;
+        for (auto& group : portGroups)
+            groups[count++] = group.second;
+
+        memset(&groups[count], 0, sizeof(PluginPortGroup));
+
+        info.portGroups = groups;
+    }
+
     // --------------------------------------------------------------------------------------------------------
     // parameters
 
@@ -3411,6 +3475,8 @@ static void _clear_port_info(PluginPort& portinfo)
         free((void*)portinfo.comment);
     if (portinfo.designation != nc)
         free((void*)portinfo.designation);
+    if (portinfo.group != nc)
+        free((void*)portinfo.group);
     if (portinfo.shortName != nc)
         free((void*)portinfo.shortName);
 
@@ -3441,6 +3507,15 @@ static void _clear_port_info(PluginPort& portinfo)
     memset(&portinfo, 0, sizeof(PluginPort));
 }
 
+static void _clear_port_group_info(const PluginPortGroup& portGroup)
+{
+    // NOTE portGroup.uri points to port.group
+    if (portGroup.symbol != nc)
+        free((void*)portGroup.symbol);
+    if (portGroup.name != nc)
+        free((void*)portGroup.name);
+}
+
 static void _clear_parameter_info(const PluginParameter& parameter)
 {
     free((void*)parameter.uri);
@@ -3610,6 +3685,13 @@ static void _clear_plugin_info(PluginInfo& info)
         delete[] info.ports.midi.output;
     }
 
+    if (info.portGroups != nullptr)
+    {
+        for (int i=0; info.portGroups[i].valid; ++i)
+            _clear_port_group_info(info.portGroups[i]);
+        delete[] info.portGroups;
+    }
+
     if (info.parameters != nullptr)
     {
         for (int i=0; info.parameters[i].valid; ++i)