chore: more backend formatting

Author: guenhter

.github/workflows/ci.yml

@@ -8,19 +8,25 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v6
-      - name: Set up Python
-        uses: actions/setup-python@v6
-        with:
-          python-version: "3.13"
+
       - name: Install uv
-        run: curl -LsSf https://astral.sh/uv/install.sh | sh
-      - name: Sync dependencies
+        uses: astral-sh/setup-uv@v7
+
+      - name: Set up Python
+        run: uv python install 3.13
+
+      - name: Install dependencies
         working-directory: backend
-        run: uv sync
+        run: uv sync --all-extras
+
       - name: Check formatting
         working-directory: backend
         run: uv run ruff format --check .
 
+      - name: Lint
+        working-directory: backend
+        run: uv run ruff check .
+
   frontend-format:
     runs-on: ubuntu-latest
     strategy:
@@ -31,15 +37,19 @@ jobs:
           - e2e_tests/tests_omni_light
     steps:
       - uses: actions/checkout@v6
+
       - name: Set up Node.js
         uses: actions/setup-node@v6
         with:
           node-version: "20"
+
       - name: Install pnpm
         run: npm install -g pnpm
+
       - name: Install dependencies
         working-directory: ${{ matrix.working-dir }}
         run: pnpm install
+
       - name: Check formatting and linting
         working-directory: ${{ matrix.working-dir }}
         run: pnpm check
@@ -48,32 +58,38 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v6
-      - name: Set up Python
-        uses: actions/setup-python@v6
-        with:
-          python-version: "3.13"
+
       - name: Install uv
-        run: curl -LsSf https://astral.sh/uv/install.sh | sh
-      - name: Sync dependencies
+        uses: astral-sh/setup-uv@v7
+
+      - name: Set up Python
+        run: uv python install 3.13
+
+      - name: Install dependencies
         working-directory: backend
-        run: uv sync
+        run: uv sync --all-extras
+
       - name: Run tests
         working-directory: backend
-        run: uv run pytest
+        run: uv run pytest -v
 
   frontend-unit:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v6
+
       - name: Set up Node.js
         uses: actions/setup-node@v6
         with:
           node-version: "20"
+
       - name: Install pnpm
         run: npm install -g pnpm
+
       - name: Install dependencies
         working-directory: frontend_omni
         run: pnpm install
+
       - name: Run unit tests
         working-directory: frontend_omni
         run: pnpm test
@@ -87,27 +103,27 @@ jobs:
           - e2e_tests/tests_omni_light
     steps:
       - uses: actions/checkout@v6
-      - name: Set up Python
-        uses: actions/setup-python@v6
-        with:
-          python-version: "3.13"
-      - name: Install uv
-        run: curl -LsSf https://astral.sh/uv/install.sh | sh
+
       - name: Set up Node.js
         uses: actions/setup-node@v6
         with:
           node-version: "20"
+
       - name: Install pnpm
         run: npm install -g pnpm
+
       - name: Install dependencies for frontend
         working-directory: frontend_omni
         run: pnpm install
+
       - name: Install dependencies for tests
         working-directory: ${{ matrix.working-dir }}
         run: pnpm install
+
       - name: Install Playwright browsers
         working-directory: ${{ matrix.working-dir }}
         run: pnpm playwright install --with-deps
+
       - name: Run Playwright tests
         working-directory: ${{ matrix.working-dir }}
         run: pnpm test

backend/src/modai/modules/chat/web_chat_router.py

@@ -1,4 +1,4 @@
-from fastapi import APIRouter, Request, Body
+from fastapi import Request, Body
 from fastapi.responses import StreamingResponse, JSONResponse
 from typing import Any, Dict, cast
 from modai.module import ModuleDependencies

backend/src/modai/modules/model_provider/central_router.py

@@ -11,7 +11,6 @@
 from modai.modules.model_provider.module import (
     ModelProviderResponse,
     ModelProviderModule,
-    ModelResponse,
     Model,
 )
 

backend/src/modai/modules/session/module.py

@@ -8,7 +8,7 @@
 import logging
 from abc import ABC, abstractmethod
 from dataclasses import dataclass
-from typing import Any, Dict
+from typing import Any
 
 from fastapi import Request, Response
 from modai.module import ModaiModule, ModuleDependencies

backend/src/modai/modules/user_settings/simple_user_settings_module.py

@@ -3,7 +3,7 @@
 This implementation delegates persistence to a UserSettingsStore module.
 """
 
-from typing import Any, Dict
+from typing import Any
 from fastapi import Request, HTTPException
 
 from modai.module import ModuleDependencies

backend/tests/abstract_model_provider_store_test.py

@@ -199,7 +199,7 @@ async def test_update_provider_with_duplicate_name_raises_exception(
         self, model_provider_store
     ):
         """Test that updating a provider to use an existing name raises an exception"""
-        provider1 = await model_provider_store.add_provider(
+        await model_provider_store.add_provider(
             name="Provider1", url="https://api1.com", properties={}
         )
         provider2 = await model_provider_store.add_provider(

backend/tests/test_authentication.py

@@ -3,14 +3,14 @@
 import pytest
 from unittest.mock import Mock, MagicMock, AsyncMock
 from fastapi.testclient import TestClient
-from fastapi import FastAPI, Request, Response
+from fastapi import FastAPI
 
 sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "src"))
 from modai.module import ModuleDependencies
 from modai.modules.authentication.password_authentication_module import (
     PasswordAuthenticationModule,
 )
-from modai.modules.session.module import SessionModule, Session
+from modai.modules.session.module import SessionModule
 from modai.modules.user_store.module import UserStore, User, UserCredentials
 
 

backend/tests/test_central_model_provider_router.py

@@ -5,8 +5,6 @@
 import sys
 import os
 import pytest
-from pathlib import Path
-from unittest.mock import AsyncMock, MagicMock
 from fastapi.testclient import TestClient
 from fastapi import FastAPI
 

backend/tests/test_chat.py

@@ -6,7 +6,6 @@
 import pytest_asyncio
 from openai import AsyncOpenAI
 from unittest.mock import Mock, AsyncMock
-from typing import AsyncGenerator
 
 sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "src"))
 from modai.module import ModuleDependencies
@@ -70,7 +69,7 @@ async def openai_client(request):
 async def test_llm_generate_response():
     """Test LLM generate_response method directly."""
     from fastapi import Request
-    from unittest.mock import Mock, AsyncMock
+    from unittest.mock import Mock
     from modai.modules.model_provider.module import (
         ModelProvidersListResponse,
         ModelProviderResponse,
@@ -139,7 +138,7 @@ async def test_llm_generate_response():
 async def test_llm_generate_response_streaming():
     """Test LLM generate_response method directly for streaming."""
     from fastapi import Request
-    from unittest.mock import Mock, AsyncMock
+    from unittest.mock import Mock
     from modai.modules.model_provider.module import (
         ModelProvidersListResponse,
         ModelProviderResponse,
@@ -210,7 +209,7 @@ async def test_llm_generate_response_streaming():
 async def test_chat_responses_api(openai_client: AsyncOpenAI, request):
     """Test chat responses API."""
 
-    client_type = request.node.callspec.params["openai_client"]
+    request.node.callspec.params["openai_client"]
     model = "gpt-4o"  # No backend_proxy
 
     # Make the request
@@ -242,7 +241,7 @@ async def test_chat_responses_api(openai_client: AsyncOpenAI, request):
 async def test_chat_responses_api_streaming(openai_client: AsyncOpenAI, request):
     """Test streaming chat responses API."""
 
-    client_type = request.node.callspec.params["openai_client"]
+    request.node.callspec.params["openai_client"]
     model = "gpt-4o"  # No backend_proxy
 
     # Make the streaming request
@@ -351,7 +350,7 @@ async def test_chat_web_module_routing_streaming():
 async def test_openai_llm_invalid_model_format():
     """Test OpenAILLMChatModule with invalid model format."""
     from fastapi import Request
-    from unittest.mock import Mock, AsyncMock
+    from unittest.mock import Mock
     from modai.modules.model_provider.module import (
         ModelProvidersListResponse,
         ModelProviderResponse,
@@ -403,7 +402,7 @@ async def test_openai_llm_invalid_model_format():
 async def test_openai_llm_provider_not_found():
     """Test OpenAILLMChatModule when provider is not found."""
     from fastapi import Request
-    from unittest.mock import Mock, AsyncMock
+    from unittest.mock import Mock
     from modai.modules.model_provider.module import ModelProvidersListResponse
 
     # Mock provider module with no providers

backend/tests/test_config_loader.py

@@ -22,7 +22,7 @@ def test_config_loader_valid_config(tmp_path: Path):
     loader = YamlConfigModule(ModuleDependencies(), {"config_path": str(config_file)})
     config = loader.get_config()
 
-    assert config["modules"]["health"]["enabled"] == True
+    assert config["modules"]["health"]["enabled"]
 
 
 def test_config_loader_invalid_yaml(tmp_path: Path):