- change signature of AddRemoteServicesWithNewClient extension method so it cannot return null value

Author: modabas

README.md

@@ -366,7 +366,7 @@ builder.Services.AddRemoteServicesWithNewClient(
   {
     client.BaseAddress = new Uri(baseAddress);
     client.Timeout = TimeSpan.FromSeconds(5);
-  })?.AddTransientHttpErrorPolicy(
+  }).AddTransientHttpErrorPolicy(
     policyBuilder => policyBuilder.CircuitBreakerAsync(5, TimeSpan.FromSeconds(30)));
 ```
 

samples/Client/Program.cs

@@ -30,7 +30,7 @@
   {
     client.BaseAddress = new Uri(baseAddress);
     client.Timeout = TimeSpan.FromSeconds(5);
-  })?.AddTransientHttpErrorPolicy(
+  }).AddTransientHttpErrorPolicy(
     policyBuilder => policyBuilder.CircuitBreakerAsync(5, TimeSpan.FromSeconds(30)));
 
 using IHost host = builder.Build();

src/ModEndpoints.RemoteServices/DependencyInjectionExtensions.cs

@@ -89,7 +89,7 @@ public static IServiceCollection AddRemoteServiceToExistingClient<TRequest>(
     return services;
   }
 
-  public static IHttpClientBuilder? AddRemoteServicesWithNewClient(
+  public static IHttpClientBuilder AddRemoteServicesWithNewClient(
     this IServiceCollection services,
     Assembly fromAssembly,
     string clientName,
@@ -130,6 +130,10 @@ public static IServiceCollection AddRemoteServiceToExistingClient<TRequest>(
           clientName);
       }
     }
+    if (clientBuilder is null)
+    {
+      throw new InvalidOperationException($"Cannot create HttpClient with client name {clientName}.");
+    }
     return clientBuilder;
   }