Dev (#31)

* - if an endpoint or route group is mapped multiple times in its configuration method, configuration steps continue to run for each of them instead of the last one
- code cleanup

* - code cleanup

* - add summary to di methods.

* - add a discriminator value to configuration context for endpoints and routes mapped multiple times. A configuration step of any component cannot run twice with same self discriminator.

* - add ComponentDiscriminator as scoped so it will be disposed after Map scope completes

* - bugfix: prevent adding default request validation service to DI multiple times.

* - add options to throw or not during service endpoint DI registration

* - service endpoints are now registered to DI as keyed service with request type as key, removing the need for serviceendpointregistry and related checks/options

* - code cleanup

* - update deps

* - added back check to ThrowOnDuplicateServiceEndpointRequest during DI registration

* - bugfix: DI registration of service endpoints with streaming response

* - refactor endpoint DI registration code for clarity

* - code cleanup

* - update test server configuration

* - rename some options
- update docs

* - bump version

Author: modabas

Directory.Build.props

@@ -18,6 +18,6 @@
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
     <PackageRequireLicenseAcceptance>True</PackageRequireLicenseAcceptance>
 
-    <Version>1.3.0</Version>
+    <Version>1.3.1</Version>
   </PropertyGroup>
 </Project>

docs/RequestValidation.md

@@ -55,7 +55,7 @@ internal class GetBookById(ServiceDbContext db)
 ```
 
 ## Disabling Default Request Validation
-Default request validation can be disabled during dependency injection by setting UseDefaultRequestValidation to false. This can be useful if you want to implement your own request validation logic or if you want to use a different validation library.
+You can opt out of default request validation by setting AddDefaultRequestValidatorService to false. This can be useful if you want to implement your own request validation logic or if you want to use a different validation library.
 
 If you are using `ModEndpoints.Core` package:
 ```csharp
@@ -64,7 +64,7 @@ var builder = WebApplication.CreateBuilder(args);
 // Add services to the container.
 builder.Services.AddModEndpointsCoreFromAssemblyContaining<MyEndpoint>(conf =>
 {
-  conf.UseDefaultRequestValidation = false;
+  conf.AddDefaultRequestValidatorService = false;
 });
 
 // ... add other services
@@ -77,7 +77,7 @@ var builder = WebApplication.CreateBuilder(args);
 // Add services to the container.
 builder.Services.AddModEndpointsFromAssemblyContaining<MyEndpoint>(conf =>
 {
-  conf.CoreOptions.UseDefaultRequestValidation = false;
+  conf.CoreOptions.AddDefaultRequestValidatorService = false;
 });
 
 // ... add other services

samples/ShowcaseWebApi/Program.cs

@@ -23,7 +23,15 @@
     var endpointFullName = endpoint.GetType().FullName;
     if (!string.IsNullOrWhiteSpace(endpointFullName))
     {
-      builder.WithName(endpointFullName);
+      var discriminator = configurationContext.Parameters.SelfDiscriminator;
+      if (discriminator == 0)
+      {
+        builder.WithName(endpointFullName);
+      }
+      else
+      {
+        builder.WithName($"{endpointFullName}_{discriminator}");
+      }
     }
   });
 

src/ModEndpoints.Core/Constants.cs

@@ -1,7 +1,18 @@
 namespace ModEndpoints.Core;
 internal static class Constants
 {
-  public const string RouteBuilderIsNullForEndpointMessage = "Route builder is null for {0} endpoint.";
-  public const string RouteBuilderIsNullForRouteGroupMessage = "Route builder is null for {0} route group.";
-  public const string RequiredServiceIsInvalidMessage = "Service resolved from dependency injection is invalid.";
+  public const string RouteBuilderIsNullForEndpointMessage =
+    "Route builder is null for {0} endpoint.";
+  public const string RequiredServiceIsInvalidMessage =
+    "Service resolved from dependency injection is invalid.";
+  public const string MissingRouteGroupConfigurationMessage =
+    "Missing route group configuration! Start configuring {0} route group by calling the MapGroup method of the builder.";
+  public const string MissingRouteGroupConfigurationLogMessage =
+    "Missing route group configuration! Start configuring {routeGroupType} route group by calling the MapGroup method of the builder.";
+  public const string MissingEndpointConfigurationMessage =
+    "Missing endpoint configuration! Start configuring {0} endpoint by calling one of the Map[HttpVerb] methods of the builder.";
+  public const string MissingEndpointConfigurationLogMessage =
+    "Missing endpoint configuration! Start configuring {endpointType} endpoint by calling one of the Map[HttpVerb] methods of the builder.";
+  public const string ServiceEndpointAlreadyRegisteredMessage =
+    "An endpoint for request type {0} is already registered.";
 }