Add more JS linting (#215)

* Enable and fix eslint/await-thenable lint
* Enable and fix eslint/no-deprecated lint
* Enable and fix no-console lint

Author: ehdr

modal-js/eslint.config.js

@@ -40,7 +40,22 @@ export default defineConfig([
       // We added this lint because `tsx` gets confused when you export types
       // without using the `type` keyword.
       "@typescript-eslint/consistent-type-exports": "error",
-      "object-shorthand": "warn",
+      "object-shorthand": "error",
+      "@typescript-eslint/await-thenable": "error",
+      "@typescript-eslint/no-deprecated": "error",
+      "no-console": "error",
+    },
+  },
+  {
+    files: ["test/legacy/**/*.{ts,mts,cts}"],
+    rules: {
+      "@typescript-eslint/no-deprecated": "off",
+    },
+  },
+  {
+    files: ["examples/**/*.{ts,mts,cts}"],
+    rules: {
+      "no-console": "off",
     },
   },
 ]);

modal-js/src/app.ts

@@ -117,6 +117,7 @@ export class App {
   /**
    * @deprecated Use {@link AppService#fromName client.apps.fromName()} instead.
    */
+  // eslint-disable-next-line @typescript-eslint/no-deprecated
   static async lookup(name: string, options: LookupOptions = {}): Promise<App> {
     return getDefaultClient().apps.fromName(name, options);
   }

modal-js/src/client.ts

@@ -469,6 +469,7 @@ export type ClientOptions = {
 /**
  * @deprecated Use {@link ModalClient `new ModalClient()`} instead.
  */
+// eslint-disable-next-line @typescript-eslint/no-deprecated
 export function initializeClient(options: ClientOptions) {
   defaultClientOptions = {
     tokenId: options.tokenId,

modal-js/src/cloud_bucket_mount.ts

@@ -39,6 +39,7 @@ export class CloudBucketMount {
         !url.hostname.endsWith("r2.cloudflarestorage.com") &&
         !url.hostname.endsWith("storage.googleapis.com")
       ) {
+        // eslint-disable-next-line no-console
         console.warn(
           "CloudBucketMount received unrecognized bucket endpoint URL. " +
             "Assuming AWS S3 configuration as fallback.",

modal-js/src/logger.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 export type LogLevel = "debug" | "info" | "warn" | "error";
 
 const LOG_LEVELS: Record<LogLevel, number> = {

modal-js/test/function.test.ts

@@ -18,7 +18,7 @@ test("FunctionCall", async () => {
 });
 
 test("FunctionCallJsMap", async () => {
-  const function_ = await Function_.lookup(
+  const function_ = await tc.functions.fromName(
     "libmodal-test-support",
     "identity_with_repr",
   );
@@ -28,7 +28,7 @@ test("FunctionCallJsMap", async () => {
 });
 
 test("FunctionCallDateTimeRoundtrip", async () => {
-  const function_ = await Function_.lookup(
+  const function_ = await tc.functions.fromName(
     "libmodal-test-support",
     "identity_with_repr",
   );

modal-js/test/image.test.ts

@@ -59,12 +59,14 @@ test("ImageFromAwsEcr", async () => {
   });
   expect(app.appId).toBeTruthy();
 
-  const image = await app.imageFromAwsEcr(
-    "459781239556.dkr.ecr.us-east-1.amazonaws.com/ecr-private-registry-test-7522615:python",
-    await tc.secrets.fromName("libmodal-aws-ecr-test", {
-      requiredKeys: ["AWS_ACCESS_KEY_ID", "AWS_SECRET_ACCESS_KEY"],
-    }),
-  );
+  const image = await tc.images
+    .fromAwsEcr(
+      "459781239556.dkr.ecr.us-east-1.amazonaws.com/ecr-private-registry-test-7522615:python",
+      await tc.secrets.fromName("libmodal-aws-ecr-test", {
+        requiredKeys: ["AWS_ACCESS_KEY_ID", "AWS_SECRET_ACCESS_KEY"],
+      }),
+    )
+    .build(app);
   expect(image.imageId).toBeTruthy();
   expect(image.imageId).toMatch(/^im-/);
 });
@@ -75,12 +77,14 @@ test("ImageFromGcpArtifactRegistry", { timeout: 30_000 }, async () => {
   });
   expect(app.appId).toBeTruthy();
 
-  const image = await app.imageFromGcpArtifactRegistry(
-    "us-east1-docker.pkg.dev/modal-prod-367916/private-repo-test/my-image",
-    await tc.secrets.fromName("libmodal-gcp-artifact-registry-test", {
-      requiredKeys: ["SERVICE_ACCOUNT_JSON"],
-    }),
-  );
+  const image = await tc.images
+    .fromGcpArtifactRegistry(
+      "us-east1-docker.pkg.dev/modal-prod-367916/private-repo-test/my-image",
+      await tc.secrets.fromName("libmodal-gcp-artifact-registry-test", {
+        requiredKeys: ["SERVICE_ACCOUNT_JSON"],
+      }),
+    )
+    .build(app);
   expect(image.imageId).toBeTruthy();
   expect(image.imageId).toMatch(/^im-/);
 });
@@ -107,7 +111,7 @@ test("CreateOneSandboxTopLevelImageAPISecret", async () => {
   });
   expect(app.appId).toBeTruthy();
 
-  const image = await tc.images.fromRegistry(
+  const image = tc.images.fromRegistry(
     "us-east1-docker.pkg.dev/modal-prod-367916/private-repo-test/my-image",
     await tc.secrets.fromName("libmodal-gcp-artifact-registry-test", {
       requiredKeys: ["REGISTRY_USERNAME", "REGISTRY_PASSWORD"],
@@ -128,7 +132,7 @@ test("ImageFromAwsEcrTopLevel", async () => {
   });
   expect(app.appId).toBeTruthy();
 
-  const image = await tc.images.fromAwsEcr(
+  const image = tc.images.fromAwsEcr(
     "459781239556.dkr.ecr.us-east-1.amazonaws.com/ecr-private-registry-test-7522615:python",
     await tc.secrets.fromName("libmodal-aws-ecr-test", {
       requiredKeys: ["AWS_ACCESS_KEY_ID", "AWS_SECRET_ACCESS_KEY"],
@@ -149,7 +153,7 @@ test("ImageFromGcpEcrTopLevel", async () => {
   });
   expect(app.appId).toBeTruthy();
 
-  const image = await tc.images.fromGcpArtifactRegistry(
+  const image = tc.images.fromGcpArtifactRegistry(
     "us-east1-docker.pkg.dev/modal-prod-367916/private-repo-test/my-image",
     await tc.secrets.fromName("libmodal-gcp-artifact-registry-test", {
       requiredKeys: ["SERVICE_ACCOUNT_JSON"],

modal-js/test/legacy/image.test.ts

@@ -89,7 +89,7 @@ test("CreateOneSandboxTopLevelImageAPISecret", async () => {
   const app = await App.lookup("libmodal-test", { createIfMissing: true });
   expect(app.appId).toBeTruthy();
 
-  const image = await Image.fromRegistry(
+  const image = Image.fromRegistry(
     "us-east1-docker.pkg.dev/modal-prod-367916/private-repo-test/my-image",
     await Secret.fromName("libmodal-gcp-artifact-registry-test", {
       requiredKeys: ["REGISTRY_USERNAME", "REGISTRY_PASSWORD"],
@@ -108,7 +108,7 @@ test("ImageFromAwsEcrTopLevel", async () => {
   const app = await App.lookup("libmodal-test", { createIfMissing: true });
   expect(app.appId).toBeTruthy();
 
-  const image = await Image.fromAwsEcr(
+  const image = Image.fromAwsEcr(
     "459781239556.dkr.ecr.us-east-1.amazonaws.com/ecr-private-registry-test-7522615:python",
     await Secret.fromName("libmodal-aws-ecr-test", {
       requiredKeys: ["AWS_ACCESS_KEY_ID", "AWS_SECRET_ACCESS_KEY"],
@@ -127,7 +127,7 @@ test("ImageFromGcpEcrTopLevel", async () => {
   const app = await App.lookup("libmodal-test", { createIfMissing: true });
   expect(app.appId).toBeTruthy();
 
-  const image = await Image.fromGcpArtifactRegistry(
+  const image = Image.fromGcpArtifactRegistry(
     "us-east1-docker.pkg.dev/modal-prod-367916/private-repo-test/my-image",
     await Secret.fromName("libmodal-gcp-artifact-registry-test", {
       requiredKeys: ["SERVICE_ACCOUNT_JSON"],

modal-js/test/legacy/sandbox.test.ts

@@ -176,7 +176,7 @@ test("SandboxWithVolume", async () => {
 
 test("SandboxWithReadOnlyVolume", async () => {
   const app = await App.lookup("libmodal-test", { createIfMissing: true });
-  const image = await Image.fromRegistry("alpine:3.21");
+  const image = Image.fromRegistry("alpine:3.21");
 
   const volume = await Volume.fromName("libmodal-test-sandbox-volume", {
     createIfMissing: true,

modal-js/test/legacy/secret.test.ts

@@ -33,7 +33,7 @@ test("SecretFromObject", async () => {
   expect(secret).toBeDefined();
 
   const app = await App.lookup("libmodal-test", { createIfMissing: true });
-  const image = await Image.fromRegistry("alpine:3.21");
+  const image = Image.fromRegistry("alpine:3.21");
 
   const sandbox = await app.createSandbox(image, {
     command: ["printenv", "key"],