Always return return code

thomasjpfan · thomasjpfan · commit 4d5225d37b86 · 2026-02-19T16:59:47.000-05:00
diff --git a/modal-go/sandbox.go b/modal-go/sandbox.go
@@ -788,7 +788,7 @@ func (sb *Sandbox) Terminate(ctx context.Context, params *SandboxTerminateParams
 
 	err = sb.Detach()
 	if err != nil {
-		return 0, err
+		return returnCode, err
 	}
 
 	return returnCode, nil

Original file line number	Diff line number	Diff line change
`@@ -788,7 +788,7 @@ func (sb Sandbox) Terminate(ctx context.Context, params SandboxTerminateParams`
`788`	`788`
`789`	`789`	`err = sb.Detach()`
`790`	`790`	`if err != nil {`
`791`		`- return 0, err`
	`791`	`+ return returnCode, err`
`792`	`792`	`}`
`793`	`793`
`794`	`794`	`return returnCode, nil`