Add port counter metrics to rdma health checks#62
Open
atoniolo76 wants to merge 5 commits intomainfrom
Open
Conversation
pawalt
reviewed
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds port counter metrics to RDMA health-checks. On EFA,
rdma_write_bytesandrdma_write_recv_bytesstore the total # of transmitted and received bytes respectively. On GCP/OCI,port_xmit_dataandport_rcv_dataare the counters for transmitted and received words. We multiply by 4 to convert these to bytes then print out the deltas from before and after the bw tests execute.I also added a simple printout of the cloud provider in
modal_bw_ib.py.Checklist
latestpython_versionfor the base image, if it is used~=x.y.zor==x.yversion < 1are pinned to patch version,==0.y.z(Modal's internal guide page for this repo is Multi-node examples guidance.)
Outside contributors
You're great! Thanks for your contribution.