Open
Conversation
luiscape
force-pushed
the
luis/oidc-auth
branch
from
1ce475a to
20e19bd
Compare
abhagwat
reviewed
Mar 27, 2026
|
|
||
| // Verify Modal workspace claim. | ||
| if len(a.oidc.AllowedWorkspaceIDs) > 0 { | ||
| if !stringInSlice(claims.WorkspaceID, a.oidc.AllowedWorkspaceIDs) { |
Contributor
There was a problem hiding this comment.
A bit nervous about this check: it should be highly unlikely, if not impossible, for e.g. a workspace ID to be a prefix of another. But can we just do a strict check here? ie split a.oidc.AllowedWorkspaceIDs by commas, put them in a hashset/list, and check that claims.WorkspaceID belongs to that set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds passwordless authentication to vprox using Modal's OIDC identity tokens. Setting
VPROX_AUTH_MODE=oidc-modalon the server enables JWT verification against Modal's OIDC issuer — on startup, the server performs OIDC discovery, fetches the JWKS signing keys, and validates every incoming token's signature, expiry, issuer, and optionally audience and workspace ID. On the client side, Modal injectsMODAL_IDENTITY_TOKENinto containers automatically; the client passes it to vprox viaVPROX_OIDC_TOKEN="$MODAL_IDENTITY_TOKEN".The auth mode is explicitly named
oidc-modalrather than genericoidcsince the token claims are Modal-specific (workspace ID, environment, app, function, container). All configuration uses theVPROX_prefix. Access control is scoped to workspace IDs only (VPROX_OIDC_ALLOWED_WORKSPACE_IDS), with a*wildcard option that logs a warning for testing use.