Skip to content

Commit fc2441d

Browse files
authored
Rollup merge of rust-lang#145269 - epage:test-env, r=jhpratt
Deprecate RUST_TEST_* env variables Like with rust-lang#139224, this is a documentation-only deprecation for now. Over time, we can - warn and then remove on use of unstable environment variables - warn on use of stable environment variables (no plan to remove due to compatibility) Longer term, we expect test runners, like `cargo test`, to provide the necessary mechanisms for environmental or persistent configuration (e.g. using cargo config which supports `.cargo/config.toml` as well as environment variables). This would include: - `RUST_TEST_THREADS` - `RUST_TEST_NOCAPTURE` - `RUST_TEST_SHUFFLE` (unstable) - `RUST_TEST_SHUFFLE_SEED` (unstable) The primary outcomes for this change are - Reducing the scope of what is expected for custom test harnesses to implement - Reduce the mechanisms that test runners, like `cargo test`, are expected to track when they are being bypassed to protect against negative interactions, e.g. `RUST_TEST_NOCAPTURE=1` when json output is being read. For testing-devex FCP, see rust-lang/testing-devex-team#10 Fixes rust-lang/testing-devex-team#10 History ------- At each step, I could not find evidence of design discussions on whether to support CLI, env, or both. The first env variable seems to come from the fact that it was being forked out of an existing env variable that had a much wider scope. At best, this seems like a way to offer a more persistent configuration for these flags but environment variables hidden away in libtest is a bit clunky and this seems like the wrong layer to handle this problem. **Originally:** `RUST_THREADS` was respected by the Rust runtime and libextra/test got this for free **2013:** rust-lang#7335 suggested splitting `RUST_TEST_TASKS` out of `RUST_THREADS`. In that issue and the implementation (rust-lang#8823). **2014:** rust-lang#13374 ask for support to disable capturing of stdout/stderr. `--nocapture` and `RUST_TEST_NOCAPTURE` were added together. **2015:** rust-lang#23525 renamed `RUST_TEST_TASKS` to `RUST_TEST_THREADS` **2016:** rust-lang#25636 asked to configure `RUST_TEST_THREADS` via `--test-threads` which was implemented in rust-lang#35414 **2021:** rust-lang#85440 asked for test randomization which was implemented in rust-lang#89082, adding `--shuffle` / RUST_TEST_SHUFFLE` and `--shuffle-seed SEED` / `RUST_TEST_SHUFFLE_SEED` Potentially relevant issues --------------------------- - rust-lang#74845
2 parents 4a80774 + b309211 commit fc2441d

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

test/src/cli.rs

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -162,18 +162,17 @@ tests whose names contain the filter are run. Multiple filter strings may
162162
be passed, which will run all tests matching any of the filters.
163163
164164
By default, all tests are run in parallel. This can be altered with the
165-
--test-threads flag or the RUST_TEST_THREADS environment variable when running
166-
tests (set it to 1).
165+
--test-threads flag when running tests (set it to 1).
167166
168-
By default, the tests are run in alphabetical order. Use --shuffle or set
169-
RUST_TEST_SHUFFLE to run the tests in random order. Pass the generated
170-
"shuffle seed" to --shuffle-seed (or set RUST_TEST_SHUFFLE_SEED) to run the
171-
tests in the same order again. Note that --shuffle and --shuffle-seed do not
172-
affect whether the tests are run in parallel.
167+
By default, the tests are run in alphabetical order. Use --shuffle to run
168+
the tests in random order. Pass the generated "shuffle seed" to
169+
--shuffle-seed to run the tests in the same order again. Note that
170+
--shuffle and --shuffle-seed do not affect whether the tests are run in
171+
parallel.
173172
174173
All tests have their standard output and standard error captured by default.
175-
This can be overridden with the --no-capture flag or setting RUST_TEST_NOCAPTURE
176-
environment variable to a value other than "0". Logging is not captured by default.
174+
This can be overridden with the --no-capture flag to a value other than "0".
175+
Logging is not captured by default.
177176
178177
Test Attributes:
179178

0 commit comments

Comments
 (0)