Skip to content

Commit 5b2b01d

Browse files
authored
Use intermediate env var for Pulumi passphrase (#4)
Addresses security concern where secrets were directly interpolated in run commands. Following GitHub's security best practices, the secret is now passed through an intermediate environment variable before being written to the file. This maintains compatibility with the existing Makefile workflow while reducing the risk of accidental secret disclosure.
1 parent 0289b61 commit 5b2b01d

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

.github/workflows/deploy.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@ jobs:
4949
credentials_json: ${{ secrets.GCP_PROD_SERVICE_ACCOUNT_KEY }}
5050

5151
- name: Deploy to Production
52+
env:
53+
PULUMI_PASSPHRASE: ${{ secrets.PULUMI_PROD_PASSPHRASE }}
5254
run: |
53-
echo "${{ secrets.PULUMI_PROD_PASSPHRASE }}" > passphrase.prod.txt
55+
echo "$PULUMI_PASSPHRASE" > passphrase.prod.txt
5456
make up

0 commit comments

Comments
 (0)