Skip to content

Commit 744709c

Browse files
committed
Improve clarity of comments for google groups
1 parent d3a3ea3 commit 744709c

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

src/google.ts

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,21 @@ GROUPS.forEach((group: Group) => {
1414

1515
new gworkspace.GroupSettings(group.name, {
1616
email: groups[group.name].email,
17-
whoCanContactOwner: 'ALL_OWNERS_CAN_CONTACT',
18-
whoCanJoin: 'INVITED_CAN_JOIN',
17+
18+
// Maximise visibility of group. It's visible in GitHub anyway
19+
whoCanViewMembership: 'ALL_IN_DOMAIN_CAN_VIEW',
20+
21+
// This specifies who can add/remove members. We want this to only be via this IaC.
22+
whoCanModerateMembers: 'NONE',
1923
whoCanLeaveGroup: 'NONE_CAN_LEAVE',
20-
whoCanModerateMembers: 'OWNERS_ONLY',
24+
whoCanJoin: 'INVITED_CAN_JOIN',
25+
26+
// We don't intend these groups to be used as mailing lists, so we set posting and viewing messages to the most restrictive settings currently available.
2127
whoCanPostMessage: 'ALL_OWNERS_CAN_POST',
22-
whoCanViewGroup: 'ALL_MEMBERS_CAN_VIEW',
23-
whoCanViewMembership: 'ALL_IN_DOMAIN_CAN_VIEW',
28+
whoCanContactOwner: 'ALL_OWNERS_CAN_CONTACT',
29+
// This is badly named, but actually means 'Permissions to view group messages'. See https://developers.google.com/workspace/admin/groups-settings/v1/reference/groups
30+
whoCanViewGroup: 'ALL_OWNERS_CAN_VIEW',
31+
2432
});
2533

2634
group.memberOf?.forEach((parentGroupKey) => {

0 commit comments

Comments
 (0)