Cache default options

Author: stephentoub

src/ModelContextProtocol/Client/McpClientFactory.cs

@@ -13,6 +13,23 @@ namespace ModelContextProtocol.Client;
 /// <summary>Provides factory methods for creating MCP clients.</summary>
 public static class McpClientFactory
 {
+    /// <summary>Default client options to use when none are supplied.</summary>
+    private static readonly McpClientOptions s_defaultClientOptions = CreateDefaultClientOptions();
+
+    /// <summary>Creates default client options to use when no options are supplied.</summary>
+    private static McpClientOptions CreateDefaultClientOptions()
+    {
+        var asmName = (Assembly.GetEntryAssembly() ?? Assembly.GetCallingAssembly()).GetName();
+        return new()
+        {
+            ClientInfo = new()
+            {
+                Name = asmName.Name ?? "McpClient",
+                Version = asmName.Version?.ToString() ?? "1.0.0",
+            },
+        };
+    }
+
     /// <summary>Creates an <see cref="IMcpClient"/>, connecting it to the specified server.</summary>
     /// <param name="serverConfig">Configuration for the target server to which the client should connect.</param>
     /// <param name="clientOptions">
@@ -36,20 +53,7 @@ public static async Task<IMcpClient> CreateAsync(
     {
         Throw.IfNull(serverConfig);
 
-        if (clientOptions is null)
-        {
-            var asmName = (Assembly.GetEntryAssembly() ?? Assembly.GetCallingAssembly()).GetName();
-
-            clientOptions ??= new()
-            {
-                ClientInfo = new()
-                {
-                    Name = asmName.Name ?? "McpClient",
-                    Version = asmName.Version?.ToString() ?? "1.0.0",
-                },
-            };
-        }
-
+        clientOptions ??= s_defaultClientOptions;
         createTransportFunc ??= CreateTransport;
 
         string endpointName = $"Client ({serverConfig.Id}: {serverConfig.Name})";