Skip to content

Commit 90423c3

Browse files
Use Assert.Skip where applicable.
1 parent 5f38894 commit 90423c3

File tree

4 files changed

+6
-13
lines changed

4 files changed

+6
-13
lines changed

Directory.Packages.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
<PackageVersion Include="Serilog.Sinks.Debug" Version="3.0.0" />
3636
<PackageVersion Include="Serilog.Sinks.File" Version="6.0.0" />
3737
<PackageVersion Include="System.Linq.AsyncEnumerable" Version="$(System10Version)" />
38-
<PackageVersion Include="xunit.v3" Version="2.0.0" />
38+
<PackageVersion Include="xunit.v3" Version="1.1.0" />
3939
<PackageVersion Include="xunit.runner.visualstudio" Version="3.0.2" />
4040
</ItemGroup>
4141
</Project>

ModelContextProtocol.sln

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,11 @@ EndProject
3131
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{B6FB2B28-D5DE-4654-BE9A-45E305DE4852}"
3232
ProjectSection(SolutionItems) = preProject
3333
Directory.Build.props = Directory.Build.props
34+
Directory.Packages.props = Directory.Packages.props
3435
global.json = global.json
3536
LICENSE = LICENSE
3637
logo.png = logo.png
38+
nuget.config = nuget.config
3739
README.MD = README.MD
3840
version.json = version.json
3941
EndProjectSection

tests/ModelContextProtocol.Tests/ClientIntegrationTests.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -537,9 +537,6 @@ public async Task SamplingViaChatClient_RequestResponseProperlyPropagated()
537537

538538
private static void SkipTestIfNoOpenAIKey()
539539
{
540-
if (string.IsNullOrEmpty(s_openAIKey))
541-
{
542-
throw SkipException.ForSkip("No OpenAI key provided. Skipping test.");
543-
}
540+
Assert.SkipWhen(s_openAIKey is null, "No OpenAI key provided. Skipping test.");
544541
}
545542
}

tests/ModelContextProtocol.Tests/SseIntegrationTests.cs

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,7 @@ public async Task ConnectAndReceiveMessage_InMemoryServer()
5757
[Trait("Execution", "Manual")]
5858
public async Task ConnectAndReceiveMessage_EverythingServerWithSse()
5959
{
60-
if (!EverythingSseServerFixture.IsDockerAvailable)
61-
{
62-
return;
63-
}
60+
Assert.SkipWhen(!EverythingSseServerFixture.IsDockerAvailable, "docker is not available");
6461

6562
using var loggerFactory = LoggerFactory.Create(builder =>
6663
builder.AddConsole()
@@ -101,10 +98,7 @@ public async Task ConnectAndReceiveMessage_EverythingServerWithSse()
10198
[Trait("Execution", "Manual")]
10299
public async Task Sampling_Sse_EverythingServer()
103100
{
104-
if (!EverythingSseServerFixture.IsDockerAvailable)
105-
{
106-
return;
107-
}
101+
Assert.SkipWhen(!EverythingSseServerFixture.IsDockerAvailable, "docker is not available");
108102

109103
// arrange
110104
using var loggerFactory = Microsoft.Extensions.Logging.LoggerFactory.Create(builder =>

0 commit comments

Comments
 (0)