Skip to content

Commit 203ceb5

Browse files
committed
feat: use custom screenshot for video-resource-server
- Use better screenshot from PR #253 comment showing actual video playback - Skip video-resource-server in screenshot generation script - Add SKIP_SERVERS set for manually maintained screenshots
1 parent 6063916 commit 203ceb5

File tree

3 files changed

+13
-2
lines changed

3 files changed

+13
-2
lines changed
131 KB
Loading
596 KB
Loading

tests/e2e/generate-grid-screenshots.spec.ts

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,16 @@ const OUTPUT_SIZE = 300;
1919
const APP_WIDTH = 500;
2020
const DEFAULT_WAIT_MS = 5000;
2121

22-
// Extra wait time for slow-loading servers (tiles, video, etc.)
22+
// Extra wait time for slow-loading servers (tiles, etc.)
2323
const EXTRA_WAIT_MS: Record<string, number> = {
2424
"map-server": 45000, // CesiumJS needs time for map tiles
25-
"video-resource": 30000, // Video needs time to load
2625
};
2726

27+
// Servers to skip (screenshots maintained manually)
28+
const SKIP_SERVERS = new Set([
29+
"video-resource", // Uses custom screenshot from PR comment
30+
]);
31+
2832
// Server configurations (excludes integration-server which is for E2E testing)
2933
const SERVERS = [
3034
{
@@ -148,6 +152,13 @@ for (const server of SERVERS) {
148152
return;
149153
}
150154

155+
// Skip servers with manually maintained screenshots
156+
if (SKIP_SERVERS.has(server.key)) {
157+
console.log(`⏭️ Skipping ${server.dir}: manually maintained screenshot`);
158+
test.skip();
159+
return;
160+
}
161+
151162
// Load the server
152163
await loadServer(page, server.name);
153164

0 commit comments

Comments
 (0)