uncomment

Author: jba

mcp/mcp_test.go

@@ -1154,19 +1154,19 @@ func TestPointerArgEquivalence(t *testing.T) {
 	}
 
 	// Then, check that we handle empty input equivalently.
-	// for _, args := range []any{nil, struct{}{}} {
-	// 	r0, err := cs.CallTool(ctx, &CallToolParams{Name: t0.Name, Arguments: args})
-	// 	if err != nil {
-	// 		t.Fatal(err)
-	// 	}
-	// 	r1, err := cs.CallTool(ctx, &CallToolParams{Name: t1.Name, Arguments: args})
-	// 	if err != nil {
-	// 		t.Fatal(err)
-	// 	}
-	// 	if diff := cmp.Diff(r0, r1); diff != "" {
-	// 		t.Errorf("CallTool(%v) with no arguments mismatch (-%s +%s):\n%s", args, t0.Name, t1.Name, diff)
-	// 	}
-	// }
+	for _, args := range []any{nil, struct{}{}} {
+		r0, err := cs.CallTool(ctx, &CallToolParams{Name: t0.Name, Arguments: args})
+		if err != nil {
+			t.Fatal(err)
+		}
+		r1, err := cs.CallTool(ctx, &CallToolParams{Name: t1.Name, Arguments: args})
+		if err != nil {
+			t.Fatal(err)
+		}
+		if diff := cmp.Diff(r0, r1); diff != "" {
+			t.Errorf("CallTool(%v) with no arguments mismatch (-%s +%s):\n%s", args, t0.Name, t1.Name, diff)
+		}
+	}
 
 	// Then, check that we handle different types of output equivalently.
 	for _, in := range []string{"nil", "empty", "ok"} {

mcp/tool.go

@@ -48,7 +48,6 @@ func unmarshalSchema(data json.RawMessage, resolved *jsonschema.Resolved, v any)
 
 // TODO: test with nil args.
 func validateSchema(resolved *jsonschema.Resolved, value any) error {
-	// log.Printf("validating %s against %#v %[2]T", schemaJSON(resolved.Schema()), value)
 	if resolved != nil {
 		if err := resolved.ApplyDefaults(value); err != nil {
 			return fmt.Errorf("applying defaults from \n\t%s\nto\n\t%v:\n%w", schemaJSON(resolved.Schema()), value, err)