address comments

Author: samthanawalla

internal/oauthex/auth_meta.go

@@ -202,8 +202,8 @@ type ClientRegistrationResponse struct {
 	ClientSecretExpiresAt time.Time `json:"client_secret_expires_at,omitempty"`
 }
 
-func (r ClientRegistrationResponse) MarshalJSON() ([]byte, error) {
-	type Alias ClientRegistrationResponse
+func (r *ClientRegistrationResponse) MarshalJSON() ([]byte, error) {
+	type alias ClientRegistrationResponse
 	var clientIDIssuedAt int64
 	var clientSecretExpiresAt int64
 
@@ -217,22 +217,22 @@ func (r ClientRegistrationResponse) MarshalJSON() ([]byte, error) {
 	return json.Marshal(&struct {
 		ClientIDIssuedAt      int64 `json:"client_id_issued_at,omitempty"`
 		ClientSecretExpiresAt int64 `json:"client_secret_expires_at,omitempty"`
-		*Alias
+		*alias
 	}{
 		ClientIDIssuedAt:      clientIDIssuedAt,
 		ClientSecretExpiresAt: clientSecretExpiresAt,
-		Alias:                 (*Alias)(&r),
+		alias:                 (*alias)(r),
 	})
 }
 
 func (r *ClientRegistrationResponse) UnmarshalJSON(data []byte) error {
-	type Alias ClientRegistrationResponse
+	type alias ClientRegistrationResponse
 	aux := &struct {
 		ClientIDIssuedAt      int64 `json:"client_id_issued_at,omitempty"`
 		ClientSecretExpiresAt int64 `json:"client_secret_expires_at,omitempty"`
-		*Alias
+		*alias
 	}{
-		Alias: (*Alias)(r),
+		alias: (*alias)(r),
 	}
 	if err := json.Unmarshal(data, &aux); err != nil {
 		return err

internal/oauthex/auth_meta_test.go

@@ -197,7 +197,7 @@ func TestClientRegistrationResponseJSON(t *testing.T) {
 		t.Run(tc.name, func(t *testing.T) {
 			// Test MarshalJSON
 			t.Run("marshal", func(t *testing.T) {
-				b, err := json.Marshal(tc.in)
+				b, err := json.Marshal(&tc.in)
 				if err != nil {
 					t.Fatalf("Marshal() error = %v", err)
 				}