mcp: use github.com/uber-go/goleak to test for leaks in unit tests

fgrosse · fgrosse · commit 0af54b492e34 · 2025-09-18T17:50:17.000+02:00
diff --git a/mcp/cmd_test.go b/mcp/cmd_test.go
@@ -18,6 +18,7 @@ import (
 
 	"github.com/google/go-cmp/cmp"
 	"github.com/modelcontextprotocol/go-sdk/mcp"
+	"go.uber.org/goleak"
 )
 
 const runAsServer = "_MCP_RUN_AS_SERVER"
@@ -35,6 +36,8 @@ func SayHi(ctx context.Context, req *mcp.CallToolRequest, args SayHiParams) (*mc
 }
 
 func TestMain(m *testing.M) {
+	goleak.VerifyTestMain(m)
+
 	// If the runAsServer variable is set, execute the relevant serverFunc
 	// instead of running tests (aka the fork and exec trick).
 	if name := os.Getenv(runAsServer); name != "" {

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@ import (`
`18`	`18`
`19`	`19`	`"github.com/google/go-cmp/cmp"`
`20`	`20`	`"github.com/modelcontextprotocol/go-sdk/mcp"`
	`21`	`+ "go.uber.org/goleak"`
`21`	`22`	`)`
`22`	`23`
`23`	`24`	`const runAsServer = "_MCP_RUN_AS_SERVER"`
`@@ -35,6 +36,8 @@ func SayHi(ctx context.Context, req mcp.CallToolRequest, args SayHiParams) (mc`
`35`	`36`	`}`
`36`	`37`
`37`	`38`	`func TestMain(m *testing.M) {`
	`39`	`+ goleak.VerifyTestMain(m)`
	`40`	`+`
`38`	`41`	`// If the runAsServer variable is set, execute the relevant serverFunc`
`39`	`42`	`// instead of running tests (aka the fork and exec trick).`
`40`	`43`	`if name := os.Getenv(runAsServer); name != "" {`