mcp: implement review feedback

Author: fgrosse

mcp/client_example_test.go

@@ -42,17 +42,17 @@ func Example_roots() {
 
 	// Connect the server and client...
 	t1, t2 := mcp.NewInMemoryTransports()
-	sess1, err := s.Connect(ctx, t1, nil)
+	serverSession, err := s.Connect(ctx, t1, nil)
 	if err != nil {
 		log.Fatal(err)
 	}
-	defer sess1.Close()
+	defer serverSession.Close()
 
-	sess2, err := c.Connect(ctx, t2, nil)
+	clientSession, err := c.Connect(ctx, t2, nil)
 	if err != nil {
 		log.Fatal(err)
 	}
-	defer sess2.Close()
+	defer clientSession.Close()
 
 	// ...and add a root. The server is notified about the change.
 	c.AddRoots(&mcp.Root{URI: "file://b"})

mcp/streamable_example_test.go

@@ -18,6 +18,7 @@ import (
 
 // !+streamablehandler
 
+// TODO: Until we have a way to clean up abandoned sessions, this test will leak goroutines (see #499)
 func ExampleStreamableHTTPHandler() {
 	// Create a new streamable handler, using the same MCP server for every request.
 	//
@@ -26,7 +27,7 @@ func ExampleStreamableHTTPHandler() {
 	server := mcp.NewServer(&mcp.Implementation{Name: "server", Version: "v0.1.0"}, nil)
 	handler := mcp.NewStreamableHTTPHandler(func(r *http.Request) *mcp.Server {
 		return server
-	}, &mcp.StreamableHTTPOptions{JSONResponse: true, Stateless: true})
+	}, &mcp.StreamableHTTPOptions{JSONResponse: true})
 	httpServer := httptest.NewServer(handler)
 	defer httpServer.Close()