Skip to content

Commit b987fd6

Browse files
committed
more review comments
1 parent d94f2f1 commit b987fd6

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

internal/docs/client.src.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ method. To receive notifications about root changes, set
2727
## Sampling
2828

2929
[Sampling](https://modelcontextprotocol.io/specification/2025-06-18/client/sampling)
30-
is a way for server's to leverage the client's AI capabilities. It is
30+
is a way for servers to leverage the client's AI capabilities. It is
3131
implemented in the SDK as follows:
3232

3333
**Client-side**: To add the `sampling` capability to a client, set
@@ -49,7 +49,7 @@ allows servers to request user inputs. It is implemented in the SDK as follows:
4949
The elicitation handler must return a result that matches the requested schema;
5050
otherwise, elicitation returns an error.
5151

52-
**Server-side**: To use eliciation from the server, call
52+
**Server-side**: To use elicitation from the server, call
5353
[`ServerSession.Elicit`](https://pkg.go.dev/github.com/modelcontextprotocol/go-sdk/mcp#ServerSession.Elicit).
5454

5555
%include ../../mcp/client_example_test.go elicitation -

internal/docs/protocol.src.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ session.
2424
[`ClientSession`](https://pkg.go.dev/github.com/modelcontextprotocol/go-sdk/mcp#ClientSession).
2525
This session is initialized during the `Connect` method, and provides methods
2626
to communicate with the server peer.
27-
- A `Server` is a logical MCP server, configure with various
27+
- A `Server` is a logical MCP server, configured with various
2828
[`ServerOptions`](https://pkg.go.dev/github.com/modelcontextprotocol/go-sdk/mcp#ServerOptions).
2929
- When a server is connected to a client using
3030
[`Server.Connect`](https://pkg.go.dev/github.com/modelcontextprotocol/go-sdk/mcp#Server.Connect),
@@ -70,7 +70,7 @@ newline-delimited JSON over its stdin/stdout.
7070

7171
**Client-side**: the client side of the `stdio` transport is implemented by
7272
[`CommandTransport`](https://pkg.go.dev/github.com/modelcontextprotocol/go-sdk/mcp#CommandTransport),
73-
which starts the a given `exec.Cmd` as a subprocess and communicates over its
73+
which starts the a `exec.Cmd` as a subprocess and communicates over its
7474
stdin/stdout.
7575

7676
**Server-side**: the server side of the `stdio` transport is implemented by

mcp/client_example_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ func Example_roots() {
6262
func Example_sampling() {
6363
ctx := context.Background()
6464

65-
// Create a client with a single root.
65+
// Create a client with a sampling handler.
6666
c := mcp.NewClient(&mcp.Implementation{Name: "client", Version: "v0.0.1"}, &mcp.ClientOptions{
6767
CreateMessageHandler: func(_ context.Context, req *mcp.CreateMessageRequest) (*mcp.CreateMessageResult, error) {
6868
return &mcp.CreateMessageResult{
@@ -102,7 +102,7 @@ func Example_elicitation() {
102102
ctx := context.Background()
103103
ct, st := mcp.NewInMemoryTransports()
104104

105-
s := mcp.NewServer(testImpl, nil)
105+
s := mcp.NewServer(&mcp.Implementation{Name: "server", Version: "v0.0.1"}, nil)
106106
ss, err := s.Connect(ctx, st, nil)
107107
if err != nil {
108108
log.Fatal(err)

mcp/mcp_example_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import (
1616

1717
// !+lifecycle
1818

19-
func Example_lifeCycle() {
19+
func Example_lifecycle() {
2020
ctx := context.Background()
2121

2222
// Create a client and server.

mcp/streamable_example_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import (
1919
// !+streamablehandler
2020

2121
func ExampleStreamableHTTPHandler() {
22-
// Create a new stramable handler, using the same MCP server for every request.
22+
// Create a new streamable handler, using the same MCP server for every request.
2323
//
2424
// Here, we configure it to serves application/json responses rather than
2525
// text/event-stream, just so the output below doesn't use random event ids.

0 commit comments

Comments
 (0)