Skip to content

Commit c12efd0

Browse files
committed
change go.mod back to 1.23.0 and comment lock inefficiency
1 parent c83604c commit c12efd0

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

auth/client.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ func (t *HTTPTransport) RoundTrip(req *http.Request) (*http.Response, error) {
8585
defer t.mu.Unlock()
8686
// If we don't have a token source, get one by following the OAuth flow.
8787
// (We may have obtained one while t.mu was not held above.)
88+
// TODO: We hold the lock for the entire OAuth flow. This could be a long
89+
// time. Is there a better way?
8890
if _, ok := t.opts.Base.(*oauth2.Transport); !ok {
8991
authHeaders := resp.Header[http.CanonicalHeaderKey("WWW-Authenticate")]
9092
ts, err := t.handler(req.Context(), OAuthHandlerArgs{

0 commit comments

Comments
 (0)