-
Notifications
You must be signed in to change notification settings - Fork 270
Closed
Labels
bugSomething isn't workingSomething isn't workingrelease blockerThis issue blocks the release milestone with which it is associated.This issue blocks the release milestone with which it is associated.
Milestone
Description
Describe the bug
The test suite contains 16 panics that occur during test cleanup/shutdown, but they do not cause test failures. All tests pass despite these panics.
To Reproduce
go test -v ./mcp | grep "panic serving" | wc -l
16The panics occur in
Line 793 in 1dcbf62
| c.logger.Error("stream context done", "error", ctx.Err()) |
Line 796 in 1dcbf62
| c.logger.Error("error receiving message", "error", err) |
c.logger during HTTP connection cleanup.
The panics occur during cleanup in these streamable/SSE-related tests:
- TestStreamableTransports
- TestStreamableServerTransport
- TestStreamableServerShutdown
- TestServerTransportCleanup
- TestStreamableGET
- TestServerInitiatedSSE
- TestClientReplay
- TestStreamableStateless
- TestTokenInfo
Why Tests Don't Fail
The panics happen in the HTTP server goroutines during connection cleanup after the test logic has completed. Go's HTTP server recovers from these panics internally and doesn't propagate them to the test framework.
Expected behavior
Tests should not contain any panics.
Logs
None
Additional context
None
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingrelease blockerThis issue blocks the release milestone with which it is associated.This issue blocks the release milestone with which it is associated.