mcp: enforce input schema type "object" #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec makes it clear that input schemas must have type "object". Enforce that. Allow "any" as an input argument type by special-casing it. Fixes modelcontextprotocol#283.
samthanawalla
approved these changes
Aug 22, 2025
findleyr
reviewed
Aug 22, 2025
Contributor
findleyr
left a comment
findleyr
left a comment
There was a problem hiding this comment.
This should have some updated doc comments on the restriction, probably on ToolFor and AddTool.
Also, we should add a test that calling ToolFor with a non-struct or map type (e.g. a slice or basic type) panics.
yasomaru
pushed a commit
to yasomaru/go-sdk
that referenced
this pull request
Aug 28, 2025
The spec makes it clear that input schemas must have type "object". Enforce that. Allow "any" as an input argument type by special-casing it. Fixes modelcontextprotocol#283.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec makes it clear that input schemas must have type "object". Enforce that.
Allow "any" as an input argument type by special-casing it.
Fixes #283.