Skip to content

Commit aa73daa

Browse files
authored
Merge branch 'main' into notification-expansion-state
2 parents 0130cf8 + e76bb0a commit aa73daa

File tree

9 files changed

+19
-15
lines changed

9 files changed

+19
-15
lines changed

.github/workflows/e2e_tests.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,10 @@ jobs:
2121
- uses: actions/checkout@v4
2222

2323
- uses: actions/setup-node@v4
24+
id: setup_node
2425
with:
25-
node-version: 18
26+
node-version-file: package.json
27+
cache: npm
2628

2729
# Cache Playwright browsers
2830
- name: Cache Playwright browsers
@@ -69,7 +71,7 @@ jobs:
6971
job-summary: true
7072
icon-style: "emojis"
7173
custom-info: |
72-
**Test Environment:** Ubuntu Latest, Node.js 18
74+
**Test Environment:** Ubuntu Latest, Node.js ${{ steps.setup_node.outputs.node-version }}
7375
**Browsers:** Chromium, Firefox
7476
7577
📊 [View Detailed HTML Report](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}) (download artifacts)

.github/workflows/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919

2020
- uses: actions/setup-node@v4
2121
with:
22-
node-version: 18
22+
node-version-file: package.json
2323
cache: npm
2424

2525
# Working around https://github.com/npm/cli/issues/4828
@@ -53,7 +53,7 @@ jobs:
5353
- uses: actions/checkout@v4
5454
- uses: actions/setup-node@v4
5555
with:
56-
node-version: 18
56+
node-version-file: package.json
5757
cache: npm
5858
registry-url: "https://registry.npmjs.org"
5959

.node-version

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
22.x.x

client/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<title>MCP Inspector</title>
88
</head>
99
<body>
10-
<div id="root"></div>
10+
<div id="root" class="w-full"></div>
1111
<script type="module" src="/src/main.tsx"></script>
1212
</body>
1313
</html>

client/src/App.css

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
#root {
2-
margin: 0 auto;
3-
}
4-
51
.logo {
62
height: 6em;
73
padding: 1.5em;

client/src/utils/configUtils.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,9 @@ const getSearchParam = (key: string): string | null => {
1414
};
1515

1616
export const getMCPProxyAddress = (config: InspectorConfig): string => {
17-
const proxyFullAddress = config.MCP_PROXY_FULL_ADDRESS.value as string;
17+
let proxyFullAddress = config.MCP_PROXY_FULL_ADDRESS.value as string;
1818
if (proxyFullAddress) {
19+
proxyFullAddress = proxyFullAddress.replace(/\/+$/, "");
1920
return proxyFullAddress;
2021
}
2122

package-lock.json

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,5 +64,8 @@
6464
"prettier": "3.3.3",
6565
"rimraf": "^6.0.1",
6666
"typescript": "^5.4.2"
67+
},
68+
"engines": {
69+
"node": ">=22.7.5"
6770
}
6871
}

server/src/mcpProxy.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,10 @@ function onClientError(error: Error) {
66
}
77

88
function onServerError(error: Error) {
9-
if (
10-
(error?.message &&
11-
error.message.includes("Error POSTing to endpoint (HTTP 404)")) ||
12-
(error?.cause && JSON.stringify(error.cause).includes("ECONNREFUSED"))
13-
) {
9+
if (error?.cause && JSON.stringify(error.cause).includes("ECONNREFUSED")) {
1410
console.error("Connection refused. Is the MCP server running?");
11+
} else if (error.message && error.message.includes("404")) {
12+
console.error("Error accessing endpoint (HTTP 404)");
1513
} else {
1614
console.error("Error from MCP server:", error);
1715
}

0 commit comments

Comments
 (0)