Skip to content

Commit b6dc2ce

Browse files
Remove transport/serverUrl parsing from start.js
Move transport configuration parsing to cli.js as suggested in PR review. The CLI entry point (cli.js) should handle config file parsing and pass parameters to start.js.
1 parent 1d89d75 commit b6dc2ce

File tree

1 file changed

+0
-24
lines changed

1 file changed

+0
-24
lines changed

client/bin/start.js

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ function getClientUrl(
1818
authDisabled,
1919
sessionToken,
2020
serverPort,
21-
transport,
22-
serverUrl,
2321
) {
2422
const host = process.env.HOST || "localhost";
2523
const baseUrl = `http://${host}:${port}`;
@@ -31,12 +29,6 @@ function getClientUrl(
3129
if (!authDisabled) {
3230
params.set("MCP_PROXY_AUTH_TOKEN", sessionToken);
3331
}
34-
if (transport) {
35-
params.set("transport", transport);
36-
}
37-
if (serverUrl) {
38-
params.set("serverUrl", serverUrl);
39-
}
4032
return params.size > 0 ? `${baseUrl}/?${params.toString()}` : baseUrl;
4133
}
4234

@@ -136,8 +128,6 @@ async function startDevClient(clientOptions) {
136128
sessionToken,
137129
abort,
138130
cancelled,
139-
transport,
140-
serverUrl,
141131
} = clientOptions;
142132
const clientCommand = "npx";
143133
const host = process.env.HOST || "localhost";
@@ -155,8 +145,6 @@ async function startDevClient(clientOptions) {
155145
authDisabled,
156146
sessionToken,
157147
SERVER_PORT,
158-
transport,
159-
serverUrl,
160148
);
161149

162150
// Give vite time to start before opening or logging the URL
@@ -190,8 +178,6 @@ async function startProdClient(clientOptions) {
190178
sessionToken,
191179
abort,
192180
cancelled,
193-
transport,
194-
serverUrl,
195181
} = clientOptions;
196182
const inspectorClientPath = resolve(
197183
__dirname,
@@ -206,8 +192,6 @@ async function startProdClient(clientOptions) {
206192
authDisabled,
207193
sessionToken,
208194
SERVER_PORT,
209-
transport,
210-
serverUrl,
211195
);
212196

213197
await spawnPromise("node", [inspectorClientPath], {
@@ -229,8 +213,6 @@ async function main() {
229213
let command = null;
230214
let parsingFlags = true;
231215
let isDev = false;
232-
let transport = null;
233-
let serverUrl = null;
234216

235217
for (let i = 0; i < args.length; i++) {
236218
const arg = args[i];
@@ -256,10 +238,6 @@ async function main() {
256238
} else {
257239
envVars[envVar] = "";
258240
}
259-
} else if (parsingFlags && arg === "--transport" && i + 1 < args.length) {
260-
transport = args[++i];
261-
} else if (parsingFlags && arg === "--server-url" && i + 1 < args.length) {
262-
serverUrl = args[++i];
263241
} else if (!command && !isDev) {
264242
command = arg;
265243
} else if (!isDev) {
@@ -319,8 +297,6 @@ async function main() {
319297
sessionToken,
320298
abort,
321299
cancelled,
322-
transport,
323-
serverUrl,
324300
};
325301

326302
await (isDev

0 commit comments

Comments
 (0)