Skip to content

Commit c463dc5

Browse files
committed
Simplify check for defaults and add another test
1 parent a85d5e7 commit c463dc5

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

client/src/utils/__tests__/schemaUtils.test.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,12 @@ describe("generateDefaultValue", () => {
108108
},
109109
});
110110
});
111+
112+
test("uses schema default value when provided", () => {
113+
expect(generateDefaultValue({ type: "string", default: "test" })).toBe(
114+
"test",
115+
);
116+
});
111117
});
112118

113119
describe("formatFieldLabel", () => {

client/src/utils/schemaUtils.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ import { JsonObject } from "./jsonPathUtils";
88
*/
99
export function generateDefaultValue(schema: JsonSchemaType): JsonValue {
1010
if ("default" in schema) {
11-
// Ensure we don't return undefined even if schema.default is undefined
12-
return schema.default === undefined ? null : schema.default;
11+
return schema.default;
1312
}
1413

1514
if (!schema.required) {

0 commit comments

Comments
 (0)