Skip to content

Commit ef6d849

Browse files
aaronpowelljpmcb
andauthored
Apply suggestions from code review
Co-authored-by: John McBride <[email protected]>
1 parent 652027d commit ef6d849

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ jobs:
9595
with:
9696
context: .
9797
push: true
98+
platforms: linux/amd64,linux/arm64
9899
tags: ${{ steps.meta.outputs.tags }}
99100
labels: ${{ steps.meta.outputs.labels }}
100101

Dockerfile

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,10 @@ RUN npm install --no-package-lock
1414
# Build the application
1515
RUN npm run build
1616

17-
ENV CLIENT_PORT=6274
18-
ENV SERVER_PORT=6277
17+
ARG CLIENT_PORT=6274
18+
ARG SERVER_PORT=6277
1919

20-
# Expose the CLIENT_PORT and SERVER_PORT
21-
EXPOSE $CLIENT_PORT
22-
EXPOSE $SERVER_PORT
20+
EXPOSE ${CLIENT_PORT} ${SERVER_PORT}
2321

2422
# Use ENTRYPOINT with CMD for arguments
2523
ENTRYPOINT ["npm", "start"]

0 commit comments

Comments
 (0)