Skip to content

Commit fa236ea

Browse files
committed
handle the case that client disconnects so that the server does not crash
1 parent c6fad3f commit fa236ea

File tree

1 file changed

+45
-17
lines changed

1 file changed

+45
-17
lines changed

server/src/index.ts

Lines changed: 45 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ let backingServerTransport: Transport | undefined;
141141

142142
app.get("/mcp", async (req, res) => {
143143
const sessionId = req.headers["mcp-session-id"] as string;
144-
console.log(`Received GET message for sessionId ${sessionId}`);
144+
console.log(`GET /mcp for sessionId ${sessionId}`);
145145
try {
146146
const transport = webAppTransports.get(
147147
sessionId,
@@ -160,7 +160,7 @@ app.get("/mcp", async (req, res) => {
160160

161161
app.post("/mcp", async (req, res) => {
162162
const sessionId = req.headers["mcp-session-id"] as string | undefined;
163-
console.log(`Received POST message for sessionId ${sessionId}`);
163+
console.log(`POST /mcp for sessionId ${sessionId}`);
164164
if (!sessionId) {
165165
try {
166166
console.log("New streamable-http connection");
@@ -228,7 +228,7 @@ app.post("/mcp", async (req, res) => {
228228

229229
app.get("/stdio", async (req, res) => {
230230
try {
231-
console.log("New connection");
231+
console.log("GET /stdio");
232232

233233
try {
234234
await backingServerTransport?.close();
@@ -254,18 +254,44 @@ app.get("/stdio", async (req, res) => {
254254
console.log("Created web app transport");
255255

256256
await webAppTransport.start();
257-
(backingServerTransport as StdioClientTransport).stderr!.on(
258-
"data",
259-
(chunk) => {
260-
webAppTransport.send({
261-
jsonrpc: "2.0",
262-
method: "notifications/stderr",
263-
params: {
264-
content: chunk.toString(),
265-
},
266-
});
267-
},
268-
);
257+
258+
// Handle client disconnection
259+
res.on('close', () => {
260+
console.log(`Client disconnected from session ${webAppTransport.sessionId}`);
261+
// Clean up the transport map
262+
webAppTransports.delete(webAppTransport.sessionId);
263+
});
264+
265+
// Create a stderr handler that checks connection state
266+
const stderrHandler = (chunk: Buffer) => {
267+
try {
268+
// Only send if the transport exists in our map (meaning it's still active)
269+
if (webAppTransports.has(webAppTransport.sessionId)) {
270+
webAppTransport.send({
271+
jsonrpc: "2.0",
272+
method: "notifications/stderr",
273+
params: {
274+
content: chunk.toString(),
275+
},
276+
});
277+
}
278+
} catch (error: any) {
279+
console.log(`Error sending stderr data to client: ${error.message}`);
280+
// If we hit an error sending, clean up the transport
281+
webAppTransports.delete(webAppTransport.sessionId);
282+
}
283+
};
284+
285+
if ((backingServerTransport as StdioClientTransport).stderr) {
286+
(backingServerTransport as StdioClientTransport).stderr!.on("data", stderrHandler);
287+
288+
// Store the handler reference so we can remove it when client disconnects
289+
res.on('close', () => {
290+
if ((backingServerTransport as StdioClientTransport).stderr) {
291+
(backingServerTransport as StdioClientTransport).stderr!.removeListener("data", stderrHandler);
292+
}
293+
});
294+
}
269295

270296
mcpProxy({
271297
transportToClient: webAppTransport,
@@ -282,7 +308,7 @@ app.get("/stdio", async (req, res) => {
282308
app.get("/sse", async (req, res) => {
283309
try {
284310
console.log(
285-
"New SSE connection. NOTE: The sse transport is deprecated and has been replaced by streamable-http",
311+
"GET /sse (NOTE: The sse transport is deprecated and has been replaced by streamable-http)",
286312
);
287313

288314
try {
@@ -324,7 +350,7 @@ app.get("/sse", async (req, res) => {
324350
app.post("/message", async (req, res) => {
325351
try {
326352
const sessionId = req.query.sessionId;
327-
console.log(`Received message for sessionId ${sessionId}`);
353+
console.log(`POST /message for sessionId ${sessionId}`);
328354

329355
const transport = webAppTransports.get(
330356
sessionId as string,
@@ -341,13 +367,15 @@ app.post("/message", async (req, res) => {
341367
});
342368

343369
app.get("/health", (req, res) => {
370+
console.log("GET /health");
344371
res.json({
345372
status: "ok",
346373
});
347374
});
348375

349376
app.get("/config", (req, res) => {
350377
try {
378+
console.log("GET /config");
351379
res.json({
352380
defaultEnvironment,
353381
defaultCommand: values.env,

0 commit comments

Comments
 (0)