fix: Use URL constructor for window.location mocking

Simplifies the mock implementation and avoids TypeScript type conflicts

Author: felixweinberger

client/src/utils/__tests__/configUtils.test.ts

@@ -8,20 +8,14 @@ import {
 import { DEFAULT_INSPECTOR_CONFIG } from "../../lib/constants";
 import { InspectorConfig } from "../../lib/configurationTypes";
 
-// Type for window with mutable location
-type WindowWithMutableLocation = Window & {
-  location: Location;
-};
-
 // Helper to mock window.location
 function mockWindowLocation(href: string) {
-  const windowWithLocation = window as unknown as WindowWithMutableLocation;
-  delete (windowWithLocation as WindowWithMutableLocation & { location?: Location }).location;
-  
-  windowWithLocation.location = {
-    ...window.location,
-    href,
-  } as Location;
+  // Use Object.defineProperty with a getter to avoid type issues
+  Object.defineProperty(window, "location", {
+    value: new URL(href),
+    writable: true,
+    configurable: true,
+  });
 }
 
 describe("configUtils", () => {
@@ -103,8 +97,11 @@ describe("configUtils", () => {
     });
 
     afterEach(() => {
-      const windowWithLocation = window as unknown as WindowWithMutableLocation;
-      windowWithLocation.location = originalLocation;
+      Object.defineProperty(window, "location", {
+        value: originalLocation,
+        writable: true,
+        configurable: true,
+      });
     });
 
     test("returns transport type from URL query parameter", () => {
@@ -148,8 +145,11 @@ describe("configUtils", () => {
     });
 
     afterEach(() => {
-      const windowWithLocation = window as unknown as WindowWithMutableLocation;
-      windowWithLocation.location = originalLocation;
+      Object.defineProperty(window, "location", {
+        value: originalLocation,
+        writable: true,
+        configurable: true,
+      });
     });
 
     test("returns serverUrl from query parameter", () => {
@@ -192,8 +192,11 @@ describe("configUtils", () => {
     });
 
     afterEach(() => {
-      const windowWithLocation = window as unknown as WindowWithMutableLocation;
-      windowWithLocation.location = originalLocation;
+      Object.defineProperty(window, "location", {
+        value: originalLocation,
+        writable: true,
+        configurable: true,
+      });
     });
 
     test("returns serverCommand from query parameter", () => {
@@ -226,8 +229,11 @@ describe("configUtils", () => {
     });
 
     afterEach(() => {
-      const windowWithLocation = window as unknown as WindowWithMutableLocation;
-      windowWithLocation.location = originalLocation;
+      Object.defineProperty(window, "location", {
+        value: originalLocation,
+        writable: true,
+        configurable: true,
+      });
     });
 
     test("returns serverArgs from query parameter", () => {