Address review comments

Signed-off-by: Christian Tzolov <[email protected]>

Author: tzolov

mcp-test/src/main/java/io/modelcontextprotocol/client/AbstractMcpAsyncClientTests.java

@@ -129,7 +129,8 @@ void testPingWithoutInitialization() {
 
 	@Test
 	void testPing() {
-		StepVerifier.create(mcpAsyncClient.initialize().then(mcpAsyncClient.ping())).verifyComplete();
+		StepVerifier.create(mcpAsyncClient.initialize().then(mcpAsyncClient.ping())).consumeNextWith(callToolResult -> {
+		}).verifyComplete();
 	}
 
 	@Test

mcp/src/main/java/io/modelcontextprotocol/client/McpAsyncClient.java

@@ -369,13 +369,12 @@ private <T> Mono<T> withInitializationCheck(String actionName,
 
 	/**
 	 * Sends a ping request to the server.
-	 * @return A Mono that completes when the server responds to the ping
+	 * @return A Mono that completes with the server's ping response
 	 */
-	public Mono<Void> ping() {
+	public Mono<Object> ping() {
 		return this.withInitializationCheck("pinging the server", initializedResult -> this.mcpSession
 			.sendRequest(McpSchema.METHOD_PING, null, new TypeReference<Object>() {
-			})
-			.then());
+			}));
 	}
 
 	// --------------------------

mcp/src/main/java/io/modelcontextprotocol/client/McpSyncClient.java

@@ -179,10 +179,11 @@ public void removeRoot(String rootUri) {
 	}
 
 	/**
-	 * Send a synchronous ping request to the server.
+	 * Send a synchronous ping request.
+	 * @return
 	 */
-	public void ping() {
-		this.delegate.ping().block();
+	public Object ping() {
+		return this.delegate.ping().block();
 	}
 
 	// --------------------------

mcp/src/test/java/io/modelcontextprotocol/client/AbstractMcpAsyncClientTests.java

@@ -130,7 +130,8 @@ void testPingWithoutInitialization() {
 
 	@Test
 	void testPing() {
-		StepVerifier.create(mcpAsyncClient.initialize().then(mcpAsyncClient.ping())).verifyComplete();
+		StepVerifier.create(mcpAsyncClient.initialize().then(mcpAsyncClient.ping())).consumeNextWith(callToolResult -> {
+		}).verifyComplete();
 	}
 
 	@Test

mcp/src/test/java/io/modelcontextprotocol/client/StdioMcpSyncClientTests.java

@@ -12,6 +12,7 @@
 import io.modelcontextprotocol.spec.ClientMcpTransport;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.Timeout;
+import reactor.core.publisher.Sinks;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
@@ -40,7 +41,7 @@ void customErrorHandlerShouldReceiveErrors() {
 		((StdioClientTransport) mcpTransport).setStdErrorHandler(error -> receivedError.set(error));
 
 		String errorMessage = "Test error";
-		((StdioClientTransport) mcpTransport).getErrorSink().emitNext(errorMessage, null);
+		((StdioClientTransport) mcpTransport).getErrorSink().emitNext(errorMessage, Sinks.EmitFailureHandler.FAIL_FAST);
 
 		assertThat(receivedError.get()).isNotNull().isEqualTo(errorMessage);
 	}