Skip to content

Commit bba41a4

Browse files
committed
fixup! Run PR validation on multiple OS
1 parent ab8c7bb commit bba41a4

File tree

3 files changed

+15
-5
lines changed

3 files changed

+15
-5
lines changed

.github/workflows/build.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,21 +13,23 @@ concurrency:
1313
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
1414

1515
jobs:
16-
validate-pr:
16+
build:
1717
runs-on: ${{ matrix.os }}
18-
name: Validate PR ${{ matrix.os }}
18+
name: ${{ matrix.name }}
1919
strategy:
2020
fail-fast: false
2121
matrix:
2222
include:
2323
- os: macos-latest-xlarge
24-
java-opts: "-Xmx8g -Dfile.encoding=UTF-8 -Djava.awt.headless=true -Dkotlin.daemon.jvm.options=-Xmx6g"
25-
gradle-task: "clean ktlintCheck assemble macosArm64Test macosX64Test koverLog koverHtmlReport"
24+
name: "macOS Build & Tests"
25+
java-opts: "-Xmx8g -Dfile.encoding=UTF-8 -Djava.awt.headless=true -Dkotlin.daemon.jvm.options=-Xmx6g -DexcludeDockerTests=true"
26+
gradle-task: "clean ktlintCheck assemble macosArm64Test macosX64Test jvmTest koverLog koverHtmlReport"
2627
test-type: "macos"
2728
- os: ubuntu-latest
29+
name: "Ubuntu Docker Tests"
2830
java-opts: "-Xmx4g -Dfile.encoding=UTF-8 -Djava.awt.headless=true -Dkotlin.daemon.jvm.options=-Xmx3g"
2931
gradle-task: "clean :kotlin-sdk-test:jvmTest"
30-
test-type: "jvm-docker"
32+
test-type: "ubuntu"
3133
env:
3234
JAVA_OPTS: "${{ matrix.java-opts }}"
3335
TS_SDK_IMAGE: "registry.jetbrains.team/p/grazi/grazie-infra-public/typescript-sdk-mcp@sha256:585bd19d0f2c3e46250da4d128cf3f2e8c155dc387026927e319f556a4fd559f"

kotlin-sdk-test/build.gradle.kts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@ kotlin {
66
jvm {
77
testRuns["test"].executionTask.configure {
88
useJUnitPlatform()
9+
if (System.getProperty("excludeDockerTests") == "true") {
10+
filter {
11+
excludeTestsMatching("*.typescript.*")
12+
}
13+
}
914
}
1015
}
1116
sourceSets {

kotlin-sdk-test/src/jvmTest/kotlin/io/modelcontextprotocol/kotlin/sdk/integration/typescript/TsTestBase.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,9 @@ abstract class TsTestBase {
144144
protected fun startTypeScriptServer(port: Int): ContainerProcess {
145145
val container = GenericContainer(tsDockerImage()).apply {
146146
withImagePullPolicy(PullPolicy.defaultPolicy())
147+
withCreateContainerCmdModifier { cmd ->
148+
cmd.withPlatform("linux/amd64")
149+
}
147150
withExposedPorts(port)
148151
mapOf(
149152
"MCP_HOST" to "0.0.0.0",

0 commit comments

Comments
 (0)