modularize sdk #208
Merged
modularize sdk #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e modules. Removed old configuration files and reorganized the source code structure
…rdcoded dependencies with version catalog, remove obsolete gradle wrapper files
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modularizes the Kotlin SDK by splitting it into separate modules (core, client, server) and reorganizes the project structure. The samples are configured as composite builds and now use shared version catalogs for dependency management.
- Splits the monolithic SDK into separate core, client, and server modules for better organization
- Configures sample projects as composite builds with shared dependency management
- Introduces centralized build configuration through custom Gradle plugins
Reviewed Changes
Copilot reviewed 63 out of 90 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| settings.gradle.kts | Adds new module includes and configures samples as composite builds |
| kotlin-sdk/build.gradle.kts | New umbrella module that combines core, client, and server modules |
| kotlin-sdk-core/build.gradle.kts | Core SDK module with multiplatform configuration |
| kotlin-sdk-client/build.gradle.kts | Client-specific functionality module |
| kotlin-sdk-server/build.gradle.kts | Server-specific functionality module |
| kotlin-sdk-test/build.gradle.kts | Test module configuration |
| samples/*/build.gradle.kts | Updated to use version catalog references |
| gradle/libs.versions.toml | Centralized dependency versions with sample dependencies |
| buildSrc/* | Custom Gradle plugins for publishing, multiplatform, and documentation |
Files not reviewed (5)
- samples/kotlin-mcp-server/.idea/.gitignore: Language not supported
- samples/kotlin-mcp-server/.idea/gradle.xml: Language not supported
- samples/kotlin-mcp-server/.idea/kotlinc.xml: Language not supported
- samples/kotlin-mcp-server/.idea/misc.xml: Language not supported
- samples/kotlin-mcp-server/.idea/vcs.xml: Language not supported
Comments suppressed due to low confidence (1)
kotlin-sdk-core/src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/shared/Protocol.kt:442
- [nitpick] The removal of the explicit
Unitreturn statement may be intentional cleanup, but could affect readability in complex exception handling blocks.
}
kotlin-sdk-core/src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/shared/ReadBuffer.kt
Show resolved
Hide resolved
…l modules separately instead of building all at once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core,client,server, closes Further split of this library into modules (e.g. api, client, server) #33lib.versions.tomlMotivation and Context
How Has This Been Tested?
locally
Breaking Changes
No
Types of changes
Checklist