Skip to content

Conversation

@Mr3zee
Copy link
Contributor

@Mr3zee Mr3zee commented Jan 20, 2025

Added Merge Queue Rules, so that all merged PRs are validated

@Mr3zee Mr3zee requested review from e5l and ignatov January 20, 2025 17:57
@e5l
Copy link
Contributor

e5l commented Jan 21, 2025

Could you tell me why validate PR was skipped?

Copy link
Contributor

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure workflow runs before merging

@Mr3zee
Copy link
Contributor Author

Mr3zee commented Jan 22, 2025

@e5l validate was skipped to omit running it on every commit pushed to a pr. However, it will be executed when put in a merge queue before merging.

It can not be tested here, because compilation is broken in main, I'll execute it in #23

@Mr3zee Mr3zee requested a review from e5l January 24, 2025 10:50
@Mr3zee Mr3zee merged commit d9ab85f into main Jan 24, 2025
3 checks passed
@Mr3zee Mr3zee deleted the validate-pr branch January 24, 2025 12:17
tinycrops pushed a commit to tinycrops/kotlin-sdk that referenced this pull request Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants